Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warning: type __ should have a camel case name such as CamelCase #54099

Closed
eddyb opened this issue Sep 10, 2018 · 3 comments
Closed

warning: type __ should have a camel case name such as CamelCase #54099

eddyb opened this issue Sep 10, 2018 · 3 comments
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@eddyb
Copy link
Member

eddyb commented Sep 10, 2018

A type with the name _X doesn't get a warning, but __ does.
@eddyb eddyb added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. labels Sep 10, 2018
@osa1 osa1 mentioned this issue Sep 10, 2018
Merged
@osa1
Copy link
Contributor

osa1 commented Sep 10, 2018

I think this was deliberately done, we even have a test about this (ui/lint/issue-54099-camel-case-underscore-types.rs):

type __ = isize; //~ ERROR type `__` should have a camel case name such as `CamelCase`

Should I update the test?

@eddyb
Copy link
Member Author

eddyb commented Sep 10, 2018

@osa1 Oh this should have a decision then?

@osa1
Copy link
Contributor

osa1 commented Sep 10, 2018

Alright. I updated my patch, it should now pass the tests. We can merge or close based on the decision.

bors added a commit that referenced this issue Sep 19, 2018
@bors
Auto merge of #54101 - osa1:issue_54099, r=nikomatsakis
4f3ff5a 
Fix camel case type warning for types with trailing underscores

Fixes #54099
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eddyb @osa1