-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic rustc 1.31.0-nightly (96064eb61 2018-10-28) running on x86_64-pc-windows-msvc: in hir_id_validator.rs:31 #55475
Labels
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
P-high
High priority
regression-from-stable-to-nightly
Performance or correctness regression from stable to nightly.
Comments
not just on Windows — affecting the playground as well:
|
Do you have a code sample which triggers this? It might be fixed by #55487 |
I dont have a test case. I noticed it when compiling `rust-analyzer` master
branch.
…On Mon, Oct 29, 2018, 8:12 PM Nick Cameron ***@***.***> wrote:
Do you have a code sample which triggers this? It might be fixed by #55487
<#55487>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#55475 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEIBRGXbKWqD66wWsruFjLDh1jkWOyd0ks5up5l0gaJpZM4X_ToK>
.
|
It did fix my case — the playground is compiling again. |
Still reproducible with nightly-x86_64-unknown-linux-gnu 13dab66 2018-11-05. |
This seems to have hit beta prematurely via a backport (see #56128) |
Pending fix in #56143 |
bors
added a commit
that referenced
this issue
Nov 22, 2018
…y, r=petrochenkov Issue 56128 segment id ice nightly Tentative fix for #56128 From what I can tell, the problem is that if you have `pub(super) use foo::{a, b}`, then when we explode the `a` and `b`, the segment ids from the `super` path were not getting cloned. However, once I fixed *that*, then I ran into a problem that the "visibility" node-ids were not present in the final HIR -- this is because the visibility of the "stem" that is returned in this case was getting reset to inherited. I don't *think* it is a problem to undo that, so that the visibility is returned unmodified. Fixes #55475 Fixes #56128 cc @nrc @petrochenkov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
P-high
High priority
regression-from-stable-to-nightly
Performance or correctness regression from stable to nightly.
Trying to build: https://github.com/rust-analyzer/rust-analyzer latest nightly rustc 1.31.0-nightly (96064eb 2018-10-28) running on x86_64-pc-windows-msvc panics.
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
note: rustc 1.31.0-nightly (96064eb 2018-10-28) running on x86_64-pc-windows-msvc
note: compiler flags: -C debuginfo=2 -C incremental --crate-type lib
note: some of the compiler flags provided by cargo are hidden
error: Could not compile
ra_syntax
.warning: build failed, waiting for other jobs to finish...
error: build failed
The text was updated successfully, but these errors were encountered: