Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from_*e_bytes and to_n*_bytes equivalents for floats #57492

Closed
clarfonthey opened this issue Jan 10, 2019 · 3 comments · Fixed by #62366
Closed

from_*e_bytes and to_n*_bytes equivalents for floats #57492

clarfonthey opened this issue Jan 10, 2019 · 3 comments · Fixed by #62366
Assignees
@rustbot
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@clarfonthey
Copy link
Contributor

clarfonthey commented Jan 10, 2019 •
edited by rustbot
Loading

These feel appropriate to add for completeness, and would simply chain from_bits or to_bits with the appropriate integer method.

I'll add a PR soon.

This issue has been assigned to @lzutao via this comment.
@estebank estebank added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jan 10, 2019
@nagisa
Copy link
Member

nagisa commented Jan 10, 2019 •
edited
Loading

Byte order conversions on floats themselves make little sense. The conversions should be done before float’s from/to_bits functions are called.

@nagisa
Copy link
Member

nagisa commented Jan 10, 2019

Err, I misread the proposal the first time around...

@tbu- tbu- mentioned this issue Feb 26, 2019
Closed
tbu- added a commit to tbu-/rust that referenced this issue Mar 18, 2019
@tbu-
Add float conversions to and from bytes
f39230e 
Use the same API as for integers.

Fixes rust-lang#57492.
@jonas-schievink jonas-schievink added the C-feature-request Category: A feature request, i.e: not implemented / a PR. label Jun 10, 2019
@tesuji tesuji mentioned this issue Jul 4, 2019
Merged
@tesuji
Copy link
Contributor

tesuji commented Jul 4, 2019

@rustbot claim

@rustbot rustbot self-assigned this Jul 4, 2019
tesuji pushed a commit to tesuji/rustc that referenced this issue Jul 8, 2019
@tbu- @tesuji
Add float conversions to and from bytes
ad47f08 
Use the same API as for integers.

Fixes rust-lang#57492.
bors added a commit that referenced this issue Jul 8, 2019
@bors
Auto merge of #62366 - lzutao:feature/float-from-to-bytes, r=SimonSapin
10840b8 
Add float conversions to and from bytes

Rework of #58756. Address #58756 (comment).

Fixes #57492.

r? @SimonSapin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustbot rustbot

Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
6 participants
@nagisa @estebank @jonas-schievink @tesuji @clarfonthey @rustbot