DOS Line Endings in install.sh on some rust-std nightlies

[apmorton]

Since the change from travis to azure pipelines some of the rust-std archives have DOS line endings in their install.sh script, which results in errors like the following when trying to execute:

# ./install.sh
bash: ./install.sh: /bin/bash^M: bad interpreter: No such file or directory

Running dos2unix install.sh works around the issue for now.

Not all archives have this issue. Specifically http://static.rust-lang.org/dist/rust-std-nightly-i686-pc-windows-gnu.tar.gz does. Possibly others as well, but our install process fails after the first error, so I am not sure.

See compiler-explorer/infra#230 and compiler-explorer/infra@4df231f

[pietroalbini]

Thanks for reporting this!

A tentative fix for this landed in #62279, hopefully tomorrow's nightlies will be fixed.

[maroux]

Still happening on 1.38.0-nightly (6e310f2ab 2019-07-07) :/

[pietroalbini]

Oh, this is concerning, we'll need to look into it a bit more. Thanks for the update.

@rustbot modify labels: regression-from-stable-to-beta -regression-from-stable-to-nightly

[maroux]

May have been rust-installer actually .. Double checking.

[mati865]

rust-src-nightly.tar.gz is also affected, does that mean src is now generated from Windows or this is broken even more than it seems?

[pietroalbini]

This is caused by the Azure migration, as it started happening right after we switched nightlies production to it. The initial hypothesis was that git's core.autocrlf on Windows was the culprit, but that landed days ago so we need to look deeper :/

[pietroalbini]

rust-src-nightly.tar.gz is also affected, does that mean src is now generated from Windows or this is broken even more than it seems?

The source tarball is generated by all the dist builders and uploaded each time, so the last dist builder to finish will be the one producing the final tarball. I think we see the error there just because our slower builders are all Windows at the moment.

[pietroalbini]

Assigning myself to investigate in the next few days.

[tesuji]

Relevant:

• https://help.github.com/en/articles/configuring-git-to-handle-line-endings
• https://git-scm.com/docs/git-config
• https://stackoverflow.com/questions/1967370/git-replacing-lf-with-crlf

[pietroalbini]

The fix should've landed in today's nightly. Thanks everyone for reporting this!

[EricRahm]

@pietroalbini Just a note, you might want to spin up a beta build as well. rust-src-beta was affected by this as well.

[pietroalbini]

@EricRahm yes, beta is still not fixed. The fix was nominated for beta backport though, so once the team approves we will backport it to the beta branch.

[pietroalbini]

We backported the change!