Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only autoderef through one box #647

Closed
msullivan opened this issue Jul 8, 2011 · 3 comments
Closed

Only autoderef through one box #647

msullivan opened this issue Jul 8, 2011 · 3 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@msullivan
Copy link
Contributor

Right now we can autoderef through multiple boxes (and we can do things like "(@@@@7) + (@@2)". This seems a little silly. I think we might want to restrict it to just go through one box?

What do people think of this? (Relatedly, I think could use a "bikeshed" label and a "language" label.)
@msullivan
Copy link
Contributor Author

Hm. One issue is now that we also autoderef through resources and unary tags. While it is somewhat silly to autoderef through two boxes it is less silly to autoderef through a box and a unary tag...

@marijnh
Copy link
Contributor

marijnh commented Jul 29, 2011

Exactly. Especially when calling methods or dereferencing fields, having deep autoderef can save a lot of syntactic clutter. I vote we keep this as it is.

@msullivan
Copy link
Contributor Author

Yeah, I think I am going to close this bug.

pdietl pushed a commit to pdietl/rust that referenced this issue Apr 23, 2020
@Centril
Merge pull request rust-lang#647 from RalfJung/sound
e922989 
Define sound and unsound
ZuseZ4 pushed a commit to EnzymeAD/rust that referenced this issue Mar 7, 2023
@tgymnich @wsmoses
Fix unwrap (rust-lang#647)
3316e62 
* fix unwrap stack overflow for vector mode

* check for exactly one knownRecomputeHeuristic.count

* added indices check

* add tests

Co-authored-by: William S. Moses <[email protected]>
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@celinval @tedinski
Fix spurious overflow counter examples. (rust-lang#558) (rust-lang#647)
60e56a9 
We cannot easily specify which arithmetic operations are wrapping ones to CBMC. Thus, CBMC was generating overflow checks for wrapping operations which were generating spurious failures. This change disables some of those CBMC checks. We replace them by using rustc overflow checks for regular operations and by explicitly adding checks to unchecked operations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marijnh @msullivan