Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming trait Ptr to UnsafePtr #6607

Closed
brson opened this issue May 19, 2013 · 4 comments
Closed

Consider renaming trait Ptr to UnsafePtr #6607

brson opened this issue May 19, 2013 · 4 comments

Comments

@brson
Copy link
Contributor

brson commented May 19, 2013

It's only used for unsafe things. When I saw it I thought it may be implemented by other types.

It doesn't help that core::ptr deals with both unsafe and borrowed pointers.

@graydon
Copy link
Contributor

graydon commented May 23, 2013

did we not decide to use "raw" for these things?

@graydon
Copy link
Contributor

graydon commented May 23, 2013

accepted for backwards-compatible milestone

@thestinger
Copy link
Contributor

@graydon: #6608 is related, we haven't really settled on unsafe vs. raw across the codebase

bors added a commit that referenced this issue Jun 3, 2013
Closes #6607

I went with `RawPtr` instead of `UnsafePtr` because not all of these operations are `unsafe`, so to me it makes more sense to refer to it as a "raw" (not wrapped/abstracted) pointer. If we decide on something else in #6608 it can be renamed again.
@thestinger
Copy link
Contributor

Fixed by #6913.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants