Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for From<NonZero*> impls for wider NonZero types #66291

Closed
peter-wilkins opened this issue Nov 11, 2019 · 5 comments · Fixed by #66277
Closed

Tracking issue for From<NonZero*> impls for wider NonZero types #66291

peter-wilkins opened this issue Nov 11, 2019 · 5 comments · Fixed by #66277
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@peter-wilkins
Copy link
Contributor

Tracking issue to convert non-zero integer types to wider non-zero integer types when the underlying type supports the conversion.

For example:

num::NonZeroU32::new(e.get() as u32).unwrap().into()

becomes

e.into()
@peter-wilkins peter-wilkins mentioned this issue Nov 11, 2019
Merged
@hellow554

This comment has been minimized.

Sign in to view
@rustbot rustbot added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Nov 11, 2019
@jonas-schievink
Copy link
Contributor

Impls don't need tracking issues as they cannot be unstable

@hellow554
Copy link
Contributor

My fault. Sorry for this! 😕

@peter-wilkins
Copy link
Contributor Author

No worries, I learned something. 😃
Is the PR still OK referencing this issue?

#[unstable(feature = "nz_int_conv", issue = "66196")]

@jonas-schievink
Copy link
Contributor

@peter-wilkins You can mark those impls as stable (since the current nightly version)

bors added a commit that referenced this issue Dec 10, 2019
@bors
Auto merge of #66277 - peter-wilkins:impl-from-wider-non-zeros, r=Sim…
8960acf 
…onSapin

From<NonZero*> impls for wider NonZero types

Closes: #66291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

From<NonZero*> impls for wider NonZero types peter-wilkins/rust
4 participants
@hellow554 @jonas-schievink @peter-wilkins @rustbot