Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy-driver no longer builds after rust-lang/rust#69262 #69269

Closed
rust-highfive opened this issue Feb 18, 2020 · 0 comments · Fixed by #69278
Closed

clippy-driver no longer builds after rust-lang/rust#69262 #69269

rust-highfive opened this issue Feb 18, 2020 · 0 comments · Fixed by #69278
Assignees
@oli-obk @Manishearth @yaahc @phansch @mcarton @llogiq @flip1995
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #69262, I observed that the tool clippy-driver no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rust-clippy is needed to fix the fallout.

cc @Dylan-DPC, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Dylan-DPC, the PR reviewer, and nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 18, 2020
@JohnTitor JohnTitor mentioned this issue Feb 18, 2020
Merged
@matthiaskrgr matthiaskrgr mentioned this issue Feb 19, 2020
Merged
bors added a commit that referenced this issue Feb 19, 2020
@bors
Auto merge of #69278 - matthiaskrgr:submodule_upd, r=Dylan-DPC
7710ae0 
submodules: update clippy from b91ae16 to 2855b21

Changes:
````
Rustup to #69194
Rustup to #69181
Add `LOG2_10` and `LOG10_2` to `approx_const` lint
Clean up imports
Use `Vec::with_capacity()` as possible
needless_doctest_main: False positive for async fn
Remove use of `TyKind`.
Use `if_chain`.
Fix ICE.
Add tests and improve checks.
Add `Future` detection for `missing_errors_doc`.
````

Fixes #69269
@bors bors closed this as completed in 076cd9e Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oli-obk oli-obk

@Manishearth Manishearth

@yaahc yaahc

@phansch phansch

@mcarton mcarton

@llogiq llogiq

@flip1995 flip1995

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

submodules: update clippy from b91ae16e to 2855b214 matthiaskrgr/rust
8 participants
@oli-obk @Manishearth @yaahc @phansch @mcarton @llogiq @rust-highfive @flip1995