Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for fn VecDeque::make_contiguous #70929

Closed
2 tasks
lcnr opened this issue Apr 8, 2020 · 10 comments · Fixed by #74559
Closed
2 tasks

Tracking Issue for fn VecDeque::make_contiguous #70929

lcnr opened this issue Apr 8, 2020 · 10 comments · Fixed by #74559
Labels
A-collections Area: `std::collection` B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@lcnr
Copy link
Contributor

lcnr commented Apr 8, 2020 •
edited
Loading

This is a tracking issue for fn make_contiguous of VecDeque.
The feature gate for the issue is #![feature(deque_make_contiguous)].

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also uses as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Implementation history
@lcnr lcnr added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Apr 8, 2020
@lcnr lcnr mentioned this issue Apr 8, 2020
Merged
@jonas-schievink jonas-schievink added A-collections Area: `std::collection` B-unstable Blocker: Implemented in the nightly compiler and unstable. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Apr 8, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Apr 8, 2020
@Dylan-DPC
Rollup merge of rust-lang#70930 - lcnr:patch-1, r=Dylan-DPC
5848209 
add tracking issue to `VecDeque::make_contiguous`

The tracking issue is rust-lang#70929
@jonhoo
Copy link
Contributor

jonhoo commented Jul 6, 2020

Are there any blockers for stabilization of this feature?

@lcnr
Copy link
Contributor Author

lcnr commented Jul 6, 2020

Don't think so, don't have the time to push this to stabilization myself though.

@jonhoo
Copy link
Contributor

jonhoo commented Jul 6, 2020

I can push this through if @jonas-schievink and @Dylan-DPC think that a stabilization PR is warranted?

@jonas-schievink
Copy link
Contributor

You'll have to ask the libs team; you can find them on Zulip

@Dylan-DPC-zz
Copy link

Normally we wait for a few months to gain any feedback (though this is small) so i'd wait a bit to see if there are any concerns

@jonhoo
Copy link
Contributor

jonhoo commented Jul 6, 2020

@Dylan-DPC This landed back in April, so it's been three months — how long do you generally want the trial period to run for?

@95th
Copy link
Contributor

95th commented Jul 12, 2020

Just here to say that I also need this feature in my application.

@jonhoo jonhoo mentioned this issue Jul 20, 2020
Closed
@jonhoo
Copy link
Contributor

jonhoo commented Jul 20, 2020

@jonas-schievink I pinged the libs team on Zulip now, so we'll see :)
Thread here: https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/vecdeque_make_contiguous

@jonhoo jonhoo mentioned this issue Jul 20, 2020
Merged
@jonhoo
Copy link
Contributor

jonhoo commented Jul 20, 2020

@95th Stabilization PR now up at #74559 🎉

@KodrAus KodrAus added the Libs-Tracked Libs issues that are tracked on the team's project board. label Jul 29, 2020
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 1, 2020
@bors
Auto merge of rust-lang#74559 - jonhoo:stabilize-vecdeque-make_contig…
eb9e7c3 
…uous, r=dtolnay

Stabilize deque_make_contiguous

Closes rust-lang#70929.

/cc @Amanieu
@bors bors closed this as completed in 2f96ce8 Sep 1, 2020
@jonhoo
Copy link
Contributor

jonhoo commented Sep 1, 2020

Will be released in 1.48 🎉

jonhoo added a commit to jonhoo/left-right that referenced this issue Dec 6, 2020
@jonhoo
Add feature for amortized resizes
aede305 
Keep in mind that since this is a feature, _all_ evmap instances get
amortized if _anything_ in the dependency graph enables the feature
(indexmap-rs/indexmap#137 (comment)).
This is unfortunate, but given that the alternative is forking evmap,
we'll go with the feature approach for now. Hopefully one day we'll have
a way to [avoid this](rust-lang/cargo#2980 (comment)).

Not landing this yet since it's nightly-only at the moment due to
certain methods [in
`atone`](https://github.com/jonhoo/atone/blob/45ae1e42deaaaaa9a919957ade49982a7ac4655b/src/lib.rs#L58).
Nightly-only will go away once
rust-lang/rust#70929 and
rust-lang/rust#74217 both stabilize. The first
one will land on next stable, but the second has some more time to go
first.
@jonhoo jonhoo mentioned this issue Dec 6, 2020
Closed
jonhoo added a commit to jonhoo/left-right that referenced this issue Dec 17, 2020
@jonhoo
Add feature for amortized resizes
0ddc937 
Keep in mind that since this is a feature, _all_ evmap instances get
amortized if _anything_ in the dependency graph enables the feature
(indexmap-rs/indexmap#137 (comment)).
This is unfortunate, but given that the alternative is forking evmap,
we'll go with the feature approach for now. Hopefully one day we'll have
a way to [avoid this](rust-lang/cargo#2980 (comment)).

Not landing this yet since it's nightly-only at the moment due to
certain methods [in
`atone`](https://github.com/jonhoo/atone/blob/45ae1e42deaaaaa9a919957ade49982a7ac4655b/src/lib.rs#L58).
Nightly-only will go away once
rust-lang/rust#70929 and
rust-lang/rust#74217 both stabilize. The first
one will land on next stable, but the second has some more time to go
first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-collections Area: `std::collection` B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize deque_make_contiguous jonhoo/rust
6 participants
@jonhoo @jonas-schievink @KodrAus @Dylan-DPC-zz @95th @lcnr