Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#73317 causes ./x.py to fail on my Mojave macOS #73574

Closed
Dante-Broggi opened this issue Jun 21, 2020 · 4 comments · Fixed by #73590
Closed

#73317 causes ./x.py to fail on my Mojave macOS #73574

Dante-Broggi opened this issue Jun 21, 2020 · 4 comments · Fixed by #73590
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Dante-Broggi
Copy link
Contributor

I tried this code:

./x.py check

I expected to see this happen: rust to check the compilation of itself.

Instead, this happened: thread 'main' panicked at 'fs::read_to_string(&file)

Meta

This seems to be caused by #73317
specifically commit 93022be9917a472f7a16410ce7cb2b76a5d3afdd
based on a git bisect

Backtrace

Updating only changed submodules
Submodules updated in 0.05 seconds
    Finished dev [unoptimized] target(s) in 0.15s
thread 'main' panicked at 'fs::read_to_string(&file) failed with No such file or directory (os error 2)', src/bootstrap/config.rs:447:32
stack backtrace:
   0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
   1: core::fmt::write
   2: std::io::Write::write_fmt
   3: std::panicking::default_hook::{{closure}}
   4: std::panicking::default_hook
   5: std::panicking::rust_panic_with_hook
   6: rust_begin_unwind
   7: std::panicking::begin_panic_fmt
   8: bootstrap::config::Config::parse::{{closure}}
   9: core::option::Option<T>::map
  10: bootstrap::config::Config::parse
  11: bootstrap::main
  12: std::rt::lang_start::{{closure}}
  13: std::rt::lang_start_internal
  14: std::rt::lang_start
  15: main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
failed to run: /Users/dantebroggi/Documents/GitHub/rust-test/build/bootstrap/debug/bootstrap -i build
Build completed unsuccessfully in 0:00:00

@Dante-Broggi Dante-Broggi added the C-bug Category: This is a bug. label Jun 21, 2020
@LeSeulArtichaut LeSeulArtichaut added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jun 21, 2020
@Mark-Simulacrum
Copy link
Member

Hm, cc @davidtwco

I suspect that maybe we're not doing the right thing if the file doesn't exist (using default values in that case)?

@poliorcetics
Copy link
Contributor

I have the exact same problem

@Mark-Simulacrum
Copy link
Member

I suspect that this can be solved with touch config.toml for the time being.

@davidtwco
Copy link
Member

Sorry about this folks, filed #73590 with a fix.

Manishearth added a commit to Manishearth/rust that referenced this issue Jun 22, 2020
…var, r=Mark-Simulacrum

bootstrap: no `config.toml` exists regression

Fixes rust-lang#73574.

This PR fixes a regression introduced in rust-lang#73317 where an oversight meant that `config.toml` was assumed to exist.
@bors bors closed this as completed in 44900f8 Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants