Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: unsigned_abs inherent method conflict #82666

Closed
Mark-Simulacrum opened this issue Mar 1, 2021 · 5 comments
Closed

regression: unsigned_abs inherent method conflict #82666

Mark-Simulacrum opened this issue Mar 1, 2021 · 5 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

One crate regressed as a result of the stabilization of #80959.

@Mark-Simulacrum Mark-Simulacrum added I-nominated T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Mar 1, 2021
@Mark-Simulacrum Mark-Simulacrum added this to the 1.51.0 milestone Mar 1, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Mar 1, 2021
@apiraino
Copy link
Contributor

apiraino commented Mar 3, 2021

The published crate for geod contains code that has been updated in the meanwhile. As of today I can successfully compile the master branch of that crate on stable, beta and latest nightly.

Prioritization Working Group thread on zulip and removing I-prioritize.

@rustbot label -I-prioritize -I-nominated

@rustbot rustbot removed I-nominated I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Mar 3, 2021
@apiraino
Copy link
Contributor

apiraino commented Mar 3, 2021

I think we can close this issue (but feel free to reopen in case I've missed something)

@apiraino apiraino closed this as completed Mar 3, 2021
@Mark-Simulacrum
Copy link
Member Author

I'll just ping @tsionyx to suggest they make a point release, but otherwise I agree we can likely close.

@tsionyx
Copy link

tsionyx commented Mar 5, 2021

@Mark-Simulacrum Thank you for pointing it out, but worry not, this crate is just my pet project. I had already noticed the described name conflict before and renamed unsigned_abs to abs_and_sign.

tsionyx added a commit to tsionyx/geod that referenced this issue Mar 5, 2021
Special update to make a crate compatible with the rustc 1.51.0
See details: rust-lang/rust#82666
@tsionyx
Copy link

tsionyx commented Mar 5, 2021

Also, I published fixed version 0.1.1 on crates.io and yanked the broken one 0.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants