Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc shows the anonymous lifetime in the foreign implementations section of re-exported traits #84634

Closed
Nemo157 opened this issue Apr 27, 2021 · 0 comments · Fixed by #97878
Closed

rustdoc shows the anonymous lifetime in the foreign implementations section of re-exported traits #84634

Nemo157 opened this issue Apr 27, 2021 · 0 comments · Fixed by #97878
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Nemo157
Copy link
Member

Nemo157 commented Apr 27, 2021 •
edited
Loading

Compare the docs for futures_core::stream::Stream vs futures::stream::Stream which is just a re-export of the former. In the original docs the anonymous lifetime on the impl<T: Stream + Unpin> Stream for &mut T is not shown, in either the sidebar or main docs

image
image

While in the re-exported docs, the anonymous lifetime is shown in both locations

image
image

(along with some other differences that probably deserve separate issues)

Reproduced locally on rustdoc 1.53.0-nightly (968425893 2021-04-26)
@Nemo157 Nemo157 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Apr 27, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jun 8, 2022
@GuillaumeGomez
Add regression test for rust-lang#84634
e846c52
@GuillaumeGomez GuillaumeGomez mentioned this issue Jun 8, 2022
Merged
@bors bors closed this as completed in d11ab85 Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add regression test for anonymous lifetimes GuillaumeGomez/rust
1 participant
@Nemo157