Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiletest: known-bug should take an issue number #98436

Closed
jackh726 opened this issue Jun 23, 2022 · 1 comment · Fixed by #98530
Closed

compiletest: known-bug should take an issue number #98436

jackh726 opened this issue Jun 23, 2022 · 1 comment · Fixed by #98530
Assignees
@davidkna
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@jackh726
Copy link
Member

jackh726 commented Jun 23, 2022 •
edited by rustbot
Loading

Basically, instead of // known-bug, do // known-bug #00000 or maybe // known-bug chalk#00?

From: https://rust-lang.zulipchat.com/#narrow/stream/326866-t-types.2Fnominated/topic/.2398095.3A.20NLL.3A.20unsound.20verification.20of.20higher.20ranked.20outlives.E2.80.A6/near/287258738
@jackh726 jackh726 added A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Jun 23, 2022
@davidkna
Copy link
Contributor

@rustbot claim

@davidkna davidkna mentioned this issue Jun 26, 2022
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this issue Jun 26, 2022
@JohnTitor
Rollup merge of rust-lang#98530 - davidkna:known-bug-ref, r=Mark-Simu…
40e4fef 
…lacrum

compiletest: add issue number param to `known-bug`

I was getting some errors while testing this, but I'm pretty sure that was unrelated to my changes.

Closes rust-lang#98436

> Basically, instead of `// known-bug`, do `// known-bug #00000` or maybe `// known-bug chalk#00`?
>
> From: https://rust-lang.zulipchat.com/#narrow/stream/326866-t-types.2Fnominated/topic/.2398095.3A.20NLL.3A.20unsound.20verification.20of.20higher.20ranked.20outlives.E2.80.A6/near/287258738

I also added an `unknown` escape-hatch because I didn't find corresponding issues for every `// known-bug`.

The syntax also ended up being `// known-bug: `, because of `set_name_value_directive`.
@bors bors closed this as completed in 13e4f87 Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidkna davidkna

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

compiletest: add issue number param to known-bug davidkna/rust
2 participants
@davidkna @jackh726