Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bootstrap compiler to 1.64 #100324

Merged
merged 3 commits into from
Aug 13, 2022
Merged

Conversation

Mark-Simulacrum
Copy link
Member

r? @jyn514 perhaps?

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 9, 2022
@rustbot
Copy link
Collaborator

rustbot commented Aug 9, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2022
@rust-log-analyzer

This comment has been minimized.

compiler/rustc_interface/src/util.rs Show resolved Hide resolved
library/core/src/hash/mod.rs Show resolved Hide resolved
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when CI passes

@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Aug 9, 2022
@Mark-Simulacrum
Copy link
Member Author

@bors r=jyn514 rollup=iffy

@bors
Copy link
Contributor

bors commented Aug 9, 2022

📌 Commit fc0e4ee40de71ec646433592e089afaa2a47b361 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2022
@bors
Copy link
Contributor

bors commented Aug 12, 2022

☔ The latest upstream changes (presumably #100456) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 12, 2022
@jyn514
Copy link
Member

jyn514 commented Aug 12, 2022

@bors p=20 (should land before rollups)

@Mark-Simulacrum
Copy link
Member Author

@bors r=jyn514 rollup=iffy

@bors
Copy link
Contributor

bors commented Aug 12, 2022

📌 Commit 1c40ef7 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 12, 2022
@bors
Copy link
Contributor

bors commented Aug 13, 2022

⌛ Testing commit 1c40ef7 with merge 46c59bb...

@bors
Copy link
Contributor

bors commented Aug 13, 2022

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 46c59bb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 13, 2022
@bors bors merged commit 46c59bb into rust-lang:master Aug 13, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 13, 2022
@bors bors mentioned this pull request Aug 13, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (46c59bb): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: ❌ relevant regressions found
mean1 max count2
Regressions ❌
(primary)
2.6% 3.1% 2
Regressions ❌
(secondary)
2.5% 3.3% 5
Improvements ✅
(primary)
-3.5% -4.7% 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.5% -4.7% 4

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions ❌
(primary)
2.2% 2.2% 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.3% -2.3% 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.1% -2.3% 2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants