Inline CStr::from_bytes_with_nul_unchecked::rt_impl

[KamilaBorowska]

Currently CStr::from_bytes_with_nul_unchecked::rt_impl is not being inlined. The following function:

pub unsafe fn from_bytes_with_nul_unchecked(bytes: &[u8]) {
    CStr::from_bytes_with_nul_unchecked(bytes);
}

Outputs the following assembly on current nightly

example::from_bytes_with_nul_unchecked:
        jmp     qword ptr [rip + _ZN4core3ffi5c_str4CStr29from_bytes_with_nul_unchecked7rt_impl17h026f29f3d6a41333E@GOTPCREL]

Meanwhile on beta this provides the following assembly:

example::from_bytes_with_nul_unchecked:
        ret

This pull request adds #[inline] annotation tort_impl to fix a code generation regression for CStr::from_bytes_with_nul_unchecked.

[rustbot]

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[rust-highfive]

r? @scottmcm

(rust-highfive has picked a reviewer for you, use r? to override)

[scottmcm]

This is a concrete type (not a generic one), so adding #[inline] for a trivial method like this is perfectly reasonable.

@bors r+ rollup

[bors]

📌 Commit de95117 has been approved by scottmcm

It is now in the queue for this repository.