Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl From<Infallible> for io::Error #100411

Closed
wants to merge 1 commit into from
Closed

impl From<Infallible> for io::Error #100411

wants to merge 1 commit into from

Conversation

Kixunil
Copy link
Contributor

@Kixunil Kixunil commented Aug 11, 2022 •
edited by Dylan-DPC
Loading

This implements the trivial conversion from (uninhabited) Infallible
error type.

If I remember correctly trait impls are insta-stable, so I marked it as such. I hope this is obvious enough to pass FCP without too much hassle.

ACP: rust-lang/libs-team#86

@Kixunil
impl From<Infallible> for io::Error
099cca4 
This implements the trivial conversion from (uninhabited) `Infallible`
error type.
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Aug 11, 2022
@rustbot
Copy link
Collaborator

rustbot commented Aug 11, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 11, 2022
@Kixunil
Copy link
Contributor Author

Kixunil commented Aug 11, 2022

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 11, 2022
@Kixunil
Copy link
Contributor Author

Kixunil commented Aug 11, 2022 •
edited
Loading

Oh, damn, forgot about ACP, sorry about that!

Filed: rust-lang/libs-team#86

@Kixunil Kixunil mentioned this pull request Aug 11, 2022
Closed
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2022
@pitaj
Copy link
Contributor

pitaj commented Jan 29, 2023

@rustbot label -S-waiting-on-review +S-waiting-on-ACP

@rustbot rustbot added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2023
@scottmcm scottmcm added the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Mar 5, 2023
@bors
Copy link
Contributor

bors commented Apr 14, 2023

☔ The latest upstream changes (presumably #110331) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 14, 2023
@Dylan-DPC Dylan-DPC removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 15, 2023
@Kixunil
Copy link
Contributor Author

Kixunil commented May 17, 2023

Closing since it got rejected in ACP.

@Kixunil Kixunil closed this May 17, 2023
@Kixunil Kixunil deleted the impl-from-infallible-for-io-error branch May 17, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
needs-fcp This change is insta-stable, so needs a completed FCP to proceed. S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Kixunil @rustbot @rust-highfive @pitaj @bors @m-ou-se @JohnCSimon @scottmcm @Dylan-DPC