Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ast and parser tweaks #100610

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Ast and parser tweaks #100610

merged 3 commits into from
Aug 16, 2022

Conversation

nnethercote
Copy link
Contributor

@nnethercote
Remove {ast,hir}::WhereEqPredicate::id.
3e04fed 
These fields are unused.
@nnethercote
Avoid unnecessary cloning in Parser::get_ident_from_generic_arg.
9619a2e
@nnethercote
Add some more AST node size assertions.
3308627 
There is some redundancy here, but the extra assertions make it easier
to keep track of relative things, e.g. `ExprKind` is the biggest part
of `Expr`.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 16, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2022
@nnethercote
Copy link
Contributor Author

These are very small, so:

@bors rollup=always

@spastorino
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 16, 2022

📌 Commit 3308627 has been approved by spastorino

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 16, 2022
Merged
TaKO8Ki added a commit to TaKO8Ki/rust that referenced this pull request Aug 16, 2022
@TaKO8Ki
Rollup merge of rust-lang#100610 - nnethercote:ast-and-parser-tweaks,…
8fa0faf 
… r=spastorino

Ast and parser tweaks

r? ``@spastorino``
@TaKO8Ki TaKO8Ki mentioned this pull request Aug 16, 2022
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 16, 2022
@bors
Auto merge of rust-lang#100626 - Dylan-DPC:rollup-mwbm7kj, r=Dylan-DPC
5746c75 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#99942 (Fix nonsense non-tupled `Fn` trait error)
 - rust-lang#100609 (Extend invalid floating point literal suffix suggestion)
 - rust-lang#100610 (Ast and parser tweaks)
 - rust-lang#100613 (compiletest: fix typo in runtest.rs)
 - rust-lang#100616 (:arrow_up: rust-analyzer)
 - rust-lang#100622 (Support 128-bit atomics on all aarch64 targets)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2e78db3 into rust-lang:master Aug 16, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 16, 2022
@nnethercote nnethercote deleted the ast-and-parser-tweaks branch August 16, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spastorino spastorino

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nnethercote @spastorino @bors @rust-highfive @rustbot