Large reorgnization of rt::io::file #10086
Conversation
| /// | ||
| /// # Failure | ||
| /// | ||
| /// This funciton will raise on the `io_error` condition if an error |
There was a problem hiding this comment.
Spelling: funciton --> function :-)
|
I think it's a little peculiar that we're adding new APIs that repeat free-standing functions and methods, since we converted/are converting the other modules to use methods where possible. |
|
That's actually a good point about freestanding functions vs methods. While I think that it's kinda convenient to be able to say On the other hand, it's pretty nice being able to say
There's a few inconsistencies that I also see when looking over things:
|
|
+1 on that. |
|
Reorganized with top-level functions that are modifiers, and Path-functions that are queries (is_dir/is_file, etc). There is one duplicated function, and that is |
These traits belong here, and were simply waiting for the std::io traits to get removed. It's time they take their rightful positions!
The invocation for making a directory should be able to specify a mode to make the directory with (instead of defaulting to one particular mode). Additionally, libuv and various OSes implement efficient versions of renaming files, so this operation is exposed as an IoFactory call.
This commit moves all thread-blocking I/O functions from the std::os module. Their replacements can be found in either std::rt::io::file or in a hidden "old_os" module inside of native::file. I didn't want to outright delete these functions because they have a lot of special casing learned over time for each OS/platform, and I imagine that these will someday get integrated into a blocking implementation of IoFactory. For now, they're moved to a private module to prevent bitrot and still have tests to ensure that they work. The api of the io::file modules has also been reworked in this commit. The open_reader and open_writer functions have had open and create counterparts created, neither of which take any arguments (allowing for easy usage). The top-level 'file::open' function was renamed to 'file::open_stream', and top-level 'file::create' and 'file::open' functions were added (same as the methods). I also removed the traits that add functionality to the platform's Path structure. It was unfortunate having to import all of these traits, and it was unclear whether they would ever be implemented for anything other than Path. For this reason, they're now just an extra impl block on Path itself. I've also expanded the extensions to a few more methods defined on Path, most of which were previously defined in std::os but now have non-thread-blocking implementations as part of using the current IoFactory. Closes rust-lang#10057
|
I'm just gonna do this all at once, don't want to leave things lingering. |
Fix new_return_no_self with recursive bounds Fix rust-lang#10041 This uses a hash set, as described in rust-lang/rust-clippy#10068 (comment) changelog: [`new_return_no_self`]: fix stack overflow when the return type is `impl Trait` and contains recursive bounds
The goal of this reorganization is to finalize the interface into rt::io::file. The idea is to have this be the "pretty much final" interface, with room for only minor tweaks later on down the road.
More information can be found in the commits, but the major bonus of this pull is destroying all thread-blocking functions in
std::osand moving a lot of code in preparation for making a native I/O factory (still to come later).