Slightly improve no return for returning function error #102650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Can you rebase on top of a recent master and run |
This comment has been minimized.
This comment has been minimized.
Fixed the CI failure. Thanks. |
|
@bors r+ |
bors
added
S-waiting-on-bors
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Oct 5, 2022
…rn-for-returning-function-error, r=compiler-errors Slightly improve no return for returning function error Fixes rust-lang#100607 The rationale is that absolute beginners will be slightly confused as to why certain lines of code in a function does not require a semicolon. (I have actually witness a beginner having this confusion). Hence, a slight rationale is added "to return this value", which signals to the user that after removing said semicolon the value is returned resolving that error. However, if this is not desirable, I welcome any other suggestions. Thanks.
This was referenced Oct 5, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 5, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#102574 (Make Hash{Set,Map}::with_hasher unstably const) - rust-lang#102650 (Slightly improve no return for returning function error) - rust-lang#102662 (rustdoc: remove no-op CSS `.code-header { display: block }`) - rust-lang#102670 (follow-up fix about 101866 to print the self type.) - rust-lang#102686 (Don't build the compiler before building rls) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Rageking8
deleted the
slightly-improve-no-return-for-returning-function-error
branch
hds
added a commit
to tokio-rs/tracing
that referenced
this pull request
Dec 27, 2022
The error message suggesting that you remove a semicolon to return a value (instead of unit) was updated slightly in rust-lang/rust#102650, which was included in Rust 1.66.0. This causes one of the tests in tracing-attributes to fail. We fix it by using the updated error message.
hds
added a commit
to tokio-rs/tracing
that referenced
this pull request
Dec 27, 2022
The error message suggesting that you remove a semicolon to return a value (instead of unit) was updated slightly in rust-lang/rust#102650, which was included in Rust 1.66.0. This causes one of the tests in tracing-attributes to fail. We fix it by using the updated error message.
hawkw
pushed a commit
to tokio-rs/tracing
that referenced
this pull request
Dec 27, 2022
The error message suggesting that you remove a semicolon to return a value (instead of unit) was updated slightly in rust-lang/rust#102650, which was included in Rust 1.66.0. This causes one of the tests in tracing-attributes to fail. We fix it by using the updated error message.
davidbarsky
pushed a commit
to tokio-rs/tracing
that referenced
this pull request
Sep 27, 2023
The error message suggesting that you remove a semicolon to return a value (instead of unit) was updated slightly in rust-lang/rust#102650, which was included in Rust 1.66.0. This causes one of the tests in tracing-attributes to fail. We fix it by using the updated error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100607
The rationale is that absolute beginners will be slightly confused as to why certain lines of code in a function does not require a semicolon. (I have actually witness a beginner having this confusion). Hence, a slight rationale is added "to return this value", which signals to the user that after removing said semicolon the value is returned resolving that error.
However, if this is not desirable, I welcome any other suggestions. Thanks.