remove HRTB from [T]::is_sorted_by{,_key}
#102977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
T-compiler
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rust-highfive
added
the
S-waiting-on-review
|
Yes, I think an ACP or similar would make sense. Marking as waiting on libs-api. |
Mark-Simulacrum
added
T-libs-api
|
@bors r+ |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 16, 2022
remove HRTB from `[T]::is_sorted_by{,_key}`
Changes the signature of `[T]::is_sorted_by{,_key}` to match `[T]::binary_search_by{,_key}` and make code like rust-lang#53485 (comment) compile.
Tracking issue: rust-lang#53485
~~Do we need an ACP for something like this?~~ Edit: Filed ACP here: rust-lang/libs-team#121
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 18, 2022
remove HRTB from `[T]::is_sorted_by{,_key}`
Changes the signature of `[T]::is_sorted_by{,_key}` to match `[T]::binary_search_by{,_key}` and make code like rust-lang#53485 (comment) compile.
Tracking issue: rust-lang#53485
~~Do we need an ACP for something like this?~~ Edit: Filed ACP here: rust-lang/libs-team#121
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 18, 2022
remove HRTB from `[T]::is_sorted_by{,_key}`
Changes the signature of `[T]::is_sorted_by{,_key}` to match `[T]::binary_search_by{,_key}` and make code like rust-lang#53485 (comment) compile.
Tracking issue: rust-lang#53485
~~Do we need an ACP for something like this?~~ Edit: Filed ACP here: rust-lang/libs-team#121
This was referenced Nov 18, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 18, 2022
…earth Rollup of 8 pull requests Successful merges: - rust-lang#102977 (remove HRTB from `[T]::is_sorted_by{,_key}`) - rust-lang#103378 (Fix mod_inv termination for the last iteration) - rust-lang#103456 (`unchecked_{shl|shr}` should use `u32` as the RHS) - rust-lang#103701 (Simplify some pointer method implementations) - rust-lang#104047 (Diagnostics `icu4x` based list formatting.) - rust-lang#104338 (Enforce that `dyn*` coercions are actually pointer-sized) - rust-lang#104498 (Edit docs for `rustc_errors::Handler::stash_diagnostic`) - rust-lang#104556 (rustdoc: use `code-header` class to format enum variants) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
since this feature is still unstable |
rustbot
removed
the
relnotes
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the signature of
[T]::is_sorted_by{,_key}to match[T]::binary_search_by{,_key}and make code like #53485 (comment) compile.Tracking issue: #53485
Do we need an ACP for something like this?Edit: Filed ACP here: rust-lang/libs-team#121