Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust transmute{,_copy} to be clearer about which of T and U is input vs output #103281

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Adjust transmute{,_copy} to be clearer about which of T and U is input vs output #103281

merged 1 commit into from
Oct 20, 2022

Conversation

thomcc
Copy link
Member

@thomcc thomcc commented Oct 20, 2022

This is essentially a documentation-only change (although it does touch code in an irrelevant way).

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 20, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Oct 20, 2022
@jyn514
Copy link
Member

jyn514 commented Oct 20, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 20, 2022

📌 Commit afd0817 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 20, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 20, 2022
@bors
Auto merge of rust-lang#103322 - matthiaskrgr:rollup-m9zgpft, r=matth…
dcb3761 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#103221 (Fix `SelfVisitor::is_self_ty` ICE)
 - rust-lang#103230 (Clarify startup)
 - rust-lang#103281 (Adjust `transmute{,_copy}` to be clearer about which of `T` and `U` is input vs output)
 - rust-lang#103288 (Fixed docs typo in `library/std/src/time.rs`)
 - rust-lang#103296 (+/- shortcut now only expand/collapse, not both)
 - rust-lang#103297 (fix typo)
 - rust-lang#103313 (Don't label `src/test` tests as `A-testsuite`)
 - rust-lang#103315 (interpret: remove an incorrect assertion)
 - rust-lang#103319 (Improve "`~const` is not allowed here" message)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@inquisitivecrystal inquisitivecrystal added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools and removed A-testsuite Area: The testsuite used to check the correctness of rustc labels Oct 20, 2022
@bors bors merged commit cfb424a into rust-lang:master Oct 20, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
8 participants
@thomcc @rustbot @rust-highfive @rust-log-analyzer @jyn514 @bors @joshtriplett @inquisitivecrystal