Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: remove no-op CSS .scrape-help { background: transparent } #104323

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

notriddle
Copy link
Contributor

It's a link. This is the default CSS for it.

It's a link. This is the default CSS for it.
@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2022

r? @CraftSpider

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 12, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass

@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Nov 12, 2022

📌 Commit fa2c081 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2022
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 12, 2022
…ckground, r=GuillaumeGomez

rustdoc: remove no-op CSS `.scrape-help { background: transparent }`

It's a link. This is the default CSS for it.
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 13, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#103650 (rustdoc: change `.src-line-numbers > span` to `.src-line-numbers > a`)
 - rust-lang#104177 (rustdoc: use consistent "popover" styling for notable traits)
 - rust-lang#104318 (Move tests)
 - rust-lang#104323 (rustdoc: remove no-op CSS `.scrape-help { background: transparent }`)
 - rust-lang#104345 (Fix up a Fluent message)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0d2e94a into rust-lang:master Nov 13, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 13, 2022
@notriddle notriddle deleted the notriddle/scrape-help-background branch November 13, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants