-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: simplify .search-results-title
CSS
#104792
Merged
bors
merged 1 commit into
rust-lang:master
from
notriddle:notriddle/crate-search-title-display
Nov 25, 2022
Merged
rustdoc: simplify .search-results-title
CSS
#104792
bors
merged 1 commit into
rust-lang:master
from
notriddle:notriddle/crate-search-title-display
Nov 25, 2022
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Nov 23, 2022
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
notriddle
force-pushed
the
notriddle/crate-search-title-display
branch
from
November 23, 2022 21:30
a90f6c6
to
2185f49
Compare
By using `display: flex`, we still get the never-wrapping layout with `#crate-search-div` maxing out and truncating its text. The title itself winds up always filling its parent, but since `#crate-search` doesn't have `flex-grow` set, it won't fill available space.
GuillaumeGomez
approved these changes
Nov 24, 2022
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 24, 2022
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 24, 2022
…itle-display, r=GuillaumeGomez rustdoc: simplify `.search-results-title` CSS By using `display: flex`, we still get the never-wrapping layout with `#crate-search-div` maxing out and truncating its text. The title itself winds up always filling its parent, but since `#crate-search` doesn't have `flex-grow` set, it won't fill available space.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 24, 2022
…itle-display, r=GuillaumeGomez rustdoc: simplify `.search-results-title` CSS By using `display: flex`, we still get the never-wrapping layout with `#crate-search-div` maxing out and truncating its text. The title itself winds up always filling its parent, but since `#crate-search` doesn't have `flex-grow` set, it won't fill available space.
This was referenced Nov 24, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 24, 2022
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#104514 (Use node_ty_opt to avoid ICE in visit_ty) - rust-lang#104704 (Allow power10-vector feature in PowerPC) - rust-lang#104747 (resolve: Don't use constructor def ids in the map for field names) - rust-lang#104773 (OpaqueCast projections are always overlapping, they can't possibly be disjoint) - rust-lang#104774 (Document split{_ascii,}_whitespace() for empty strings) - rust-lang#104780 (make `error_reported` check for delayed bugs) - rust-lang#104782 (Bump the const eval step limit) - rust-lang#104792 (rustdoc: simplify `.search-results-title` CSS) - rust-lang#104796 (lint: do not warn unused parens around higher-ranked function pointers) - rust-lang#104820 (Remove normalize_projection_type) - rust-lang#104822 (with_query_mode -> new) Failed merges: - rust-lang#104716 (move 2 candidates into builtin candidate) - rust-lang#104841 (Assert that we don't capture escaping bound vars in `Fn` trait selection) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
display: flex
, we still get the never-wrapping layout with#crate-search-div
maxing out and truncating its text. The title itself winds up always filling its parent, but since#crate-search
doesn't haveflex-grow
set, it won't fill available space.