Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up pr 104954 #105038

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Clean up pr 104954 #105038

merged 1 commit into from
Nov 29, 2022

Conversation

Rageking8
Copy link
Contributor

UI test filename typo fix and a simple comment rewording. Thanks.

CC @vincenzopalazzo (you spelled your name wrongly in the FIXME)

r? @estebank

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 29, 2022
vincenzopalazzo
vincenzopalazzo approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for typo check!

After the bless for me is good to go

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 29, 2022

📌 Commit c95dceb has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2022
@bors
Auto merge of rust-lang#105041 - matthiaskrgr:rollup-7ffry90, r=matth…
0c6b88d 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#104465 (Document more settings for building rustc for Fuchsia)
 - rust-lang#104951 (Simplify checking for `GeneratorKind::Async`)
 - rust-lang#104959 (Revert rust-lang#104269 (to avoid spurious hang/test failure in CI))
 - rust-lang#104978 (notify the rust-analyzer team on changes to the rust-analyzer subtree)
 - rust-lang#105010 (Fix documentation of asymptotic complexity for rustc_data_structures::SortedMap)
 - rust-lang#105016 (Add sentence when rustdoc search is running)
 - rust-lang#105020 (rustdoc: merge background-image rules in rustdoc-toggle CSS)
 - rust-lang#105024 (rustdoc: remove `fnname` CSS class that's styled exactly like `fn`)
 - rust-lang#105027 (Rustdoc-Json: Add tests for linking to foreign variants.)
 - rust-lang#105038 (Clean up pr 104954)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 789b70d into rust-lang:master Nov 29, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 29, 2022
@Rageking8 Rageking8 deleted the clean-up-pr-104954 branch November 30, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Rageking8 @rust-log-analyzer @compiler-errors @bors @vincenzopalazzo @estebank @rustbot