Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/test: add UI test and long-form error docs for E0462 #105970

Merged
merged 1 commit into from
Dec 24, 2022
Merged

docs/test: add UI test and long-form error docs for E0462 #105970

merged 1 commit into from
Dec 24, 2022

Conversation

Ezrashaw
Copy link
Contributor

Another UI test/ docs combo.

r? @GuillaumeGomez

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 20, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2022

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@Ezrashaw
Copy link
Contributor Author

I have another for E0461 but I'm not sure its UI test will build on non-Linux platforms.

@GuillaumeGomez
Copy link
Member

I have another for E0461 but I'm not sure its UI test will build on non-Linux platforms.

You can specify a target if you want by adding a comment at the top of the file looking like // only-windows.

@Ezrashaw
Copy link
Contributor Author

I have another for E0461 but I'm not sure its UI test will build on non-Linux platforms.

You can specify a target if you want by adding a comment at the top of the file looking like // only-windows.

Yeah, maybe that'll work. Might take a couple tries to pass CI though.

@rustbot rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Dec 20, 2022
@Ezrashaw Ezrashaw force-pushed the add-docs+test-e0462 branch 4 times, most recently from 153eab7 to 5ccdebc Compare December 20, 2022 21:08
@Ezrashaw
Copy link
Contributor Author

Ezrashaw commented Dec 22, 2022 •
edited
Loading

@GuillaumeGomez I think this is good to go?

@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 22, 2022

📌 Commit 5ccdebc has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 22, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 22, 2022
@matthiaskrgr
Rollup merge of rust-lang#105970 - Ezrashaw:add-docs+test-e0462, r=Gu…
3710da7 
…illaumeGomez

docs/test: add UI test and long-form error docs for E0462

Another UI test/ docs combo.

r? `@GuillaumeGomez`
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 22, 2022
Closed
@matthiaskrgr
Copy link
Member

@bors r- failed in a rollup
#106042

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 22, 2022
@Ezrashaw Ezrashaw force-pushed the add-docs+test-e0462 branch from 5ccdebc to 66ed181 Compare December 22, 2022 21:56
@Ezrashaw
Copy link
Contributor Author

@matthiaskrgr Fixed, the UI test stderr was Linux-specific. I copied test headers from E0464 to make it work for all platforms.

@GuillaumeGomez
Copy link
Member

Let's try again then.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 23, 2022

📌 Commit 66ed181 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 23, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 23, 2022
@matthiaskrgr
Rollup merge of rust-lang#105970 - Ezrashaw:add-docs+test-e0462, r=Gu…
441c32a 
…illaumeGomez

docs/test: add UI test and long-form error docs for E0462

Another UI test/ docs combo.

r? `@GuillaumeGomez`
This was referenced Dec 23, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 24, 2022
@bors
Auto merge of rust-lang#106103 - matthiaskrgr:rollup-8xe9ddz, r=matth…
6c0c6d6 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#105970 (docs/test: add UI test and long-form error docs for E0462)
 - rust-lang#105975 (rustc: Remove needless lifetimes)
 - rust-lang#106069 (rustdoc: use a more evocative name for CSS/JS `#titles`)
 - rust-lang#106084 (fix vec::IntoIter::drop on high-alignment ZST)
 - rust-lang#106091 (Use correct CSS pseudo-element selector)
 - rust-lang#106093 (rustdoc: remove no-op CSS from `.docblock-short`)
 - rust-lang#106102 (Fix `triagebot.toml`)

Failed merges:

 - rust-lang#106028 (docs/test: add UI test and long-form error docs for `E0461`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e08dd9d into rust-lang:master Dec 24, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 24, 2022
@Ezrashaw Ezrashaw deleted the add-docs+test-e0462 branch December 27, 2022 09:02
@Ezrashaw Ezrashaw mentioned this pull request Dec 29, 2022
Merged
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@matthiaskrgr
Rollup merge of rust-lang#105970 - Ezrashaw:add-docs+test-e0462, r=Gu…
ecf3d57 
…illaumeGomez

docs/test: add UI test and long-form error docs for E0462

Another UI test/ docs combo.

r? ``@GuillaumeGomez``
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#106103 - matthiaskrgr:rollup-8xe9ddz, r=matth…
3c5198d 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#105970 (docs/test: add UI test and long-form error docs for E0462)
 - rust-lang#105975 (rustc: Remove needless lifetimes)
 - rust-lang#106069 (rustdoc: use a more evocative name for CSS/JS `#titles`)
 - rust-lang#106084 (fix vec::IntoIter::drop on high-alignment ZST)
 - rust-lang#106091 (Use correct CSS pseudo-element selector)
 - rust-lang#106093 (rustdoc: remove no-op CSS from `.docblock-short`)
 - rust-lang#106102 (Fix `triagebot.toml`)

Failed merges:

 - rust-lang#106028 (docs/test: add UI test and long-form error docs for `E0461`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Ezrashaw @rustbot @GuillaumeGomez @bors @matthiaskrgr