Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse and recover from type ascription in patterns #107602

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Parse and recover from type ascription in patterns #107602

merged 1 commit into from
Feb 3, 2023

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Feb 2, 2023

Reintroduce part of #106960, which was reverted in #107478.

r? @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 2, 2023
compiler-errors
compiler-errors approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after fixing some of these names

compiler/rustc_parse/src/parser/diagnostics.rs Outdated Show resolved Hide resolved
compiler/rustc_parse/src/parser/pat.rs Outdated Show resolved Hide resolved
tests/ui/parser/anon-enums-access.rs Outdated Show resolved Hide resolved
@estebank
Copy link
Contributor Author

estebank commented Feb 2, 2023

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Feb 2, 2023

📌 Commit 0ba687a has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 3, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 3, 2023
@bors
Auto merge of rust-lang#107625 - matthiaskrgr:rollup-xr9oldy, r=matth…
7c46fb2 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#106575 (Suggest `move` in nested closure when appropriate)
 - rust-lang#106805 (Suggest `{var:?}` when finding `{?:var}` in inline format strings)
 - rust-lang#107500 (Add tests to assert current behavior of large future sizes)
 - rust-lang#107598 (Fix benchmarks in library/core with black_box)
 - rust-lang#107602 (Parse and recover from type ascription in patterns)
 - rust-lang#107608 (Use triple rather than arch for fuchsia test-runner)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 743ca67 into rust-lang:master Feb 3, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 3, 2023
@estebank estebank deleted the anon-enum-access branch November 9, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
4 participants
@estebank @bors @compiler-errors @rustbot