Intern external constraints in new solver #107621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
compiler-errors
force-pushed
the
intern-external-constraints
branch
from
18eb9f8 to
eb67e26
Compare
lcnr
reviewed
Feb 3, 2023
| @@ -0,0 +1,55 @@ | |||
| use std::ops::ControlFlow; | |||
There was a problem hiding this comment.
please add this file to the auto notifs file for the initiative
| @@ -437,18 +428,18 @@ impl<'tcx> EvalCtxt<'_, 'tcx> { | |||
| } | |||
|
|
|||
| #[instrument(level = "debug", skip(infcx), ret)] | |||
| fn take_external_constraints<'tcx>( | |||
| fn take_and_intern_external_constraints<'tcx>( | |||
There was a problem hiding this comment.
i feel like the intern isn't too useful here as the exact way external constraints are stored is irrelevant for the caller 🤔
would keep the current name (or actually rename it to compute_external_query_constraints or sth)
compiler-errors
force-pushed
the
intern-external-constraints
branch
from
eb67e26 to
a41655d
Compare
compiler-errors
force-pushed
the
intern-external-constraints
branch
from
a41655d to
41883fd
Compare
rustbot
added
the
A-meta
|
@bors r=lcnr rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 3, 2023
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#106887 (Make const/fn return params more suggestable) - rust-lang#107519 (Add type alias for raw OS errors) - rust-lang#107551 ( Replace `ConstFnMutClosure` with const closures ) - rust-lang#107595 (Retry opening proc-macro DLLs a few times on Windows.) - rust-lang#107615 (Replace nbsp in all rustdoc code blocks) - rust-lang#107621 (Intern external constraints in new solver) - rust-lang#107631 (loudly tell people when they change `Cargo.lock`) - rust-lang#107632 (Clarifying that .map() returns None if None.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the query response
Copy, fixing a few FIXMEs.