Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Arc as Lrc for parallel compiler #109480

Closed
wants to merge 1 commit into from

Conversation

SparrowLii
Copy link
Member

part of #101566

Test perf of Lrc and make optimization

@rustbot
Copy link
Collaborator

rustbot commented Mar 22, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 22, 2023
@SparrowLii SparrowLii changed the title use Arc as Lrc test perf of Shared for parallel compiler Mar 22, 2023
@SparrowLii SparrowLii changed the title test perf of Shared for parallel compiler test perf of Lrc for parallel compiler Mar 22, 2023
@SparrowLii
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 22, 2023
@bors
Copy link
Contributor

bors commented Mar 22, 2023

⌛ Trying commit 8c40102 with merge b1dc84ef05b47984bedf7ee679a75b84d7854b59...

@bors
Copy link
Contributor

bors commented Mar 22, 2023

☀️ Try build successful - checks-actions
Build commit: b1dc84ef05b47984bedf7ee679a75b84d7854b59 (b1dc84ef05b47984bedf7ee679a75b84d7854b59)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b1dc84ef05b47984bedf7ee679a75b84d7854b59): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.5% [0.5%, 0.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.4% [-4.7%, -0.4%] 19
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.7% [0.7%, 0.7%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.8% [-0.9%, -0.8%] 3
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.6% [0.5%, 0.7%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.5% [-0.6%, -0.4%] 2
All ❌✅ (primary) - - 0

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 23, 2023
@jackh726
Copy link
Member

@SparrowLii what do you want to do with this PR?

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2023
@SparrowLii
Copy link
Member Author

SparrowLii commented Mar 28, 2023

@jackh726 This is a step to land parallel compiler. Since use Arc as Lrc doesn't impact the perf, I think we can just replace it

@SparrowLii SparrowLii marked this pull request as ready for review March 28, 2023 02:25
@SparrowLii SparrowLii changed the title test perf of Lrc for parallel compiler Use Arc as Lrc for parallel compiler Mar 28, 2023
@SparrowLii
Copy link
Member Author

SparrowLii commented Mar 28, 2023

I think we can just leave it here and merge it when the other work of parallel compilation is done.

@SparrowLii SparrowLii marked this pull request as draft March 28, 2023 02:28
@jackh726
Copy link
Member

I'm not sure it's worth leaving this open for some undefined period of time. Perf seems good enough to merge if you'd like to do that. Otherwise, I think we should just close it.

@SparrowLii
Copy link
Member Author

That makes sense. We'd better close it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants