-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Arc
as Lrc
for parallel compiler
#109480
Conversation
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 8c40102 with merge b1dc84ef05b47984bedf7ee679a75b84d7854b59... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (b1dc84ef05b47984bedf7ee679a75b84d7854b59): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
@SparrowLii what do you want to do with this PR? @rustbot author |
@jackh726 This is a step to land parallel compiler. Since use |
Arc
as Lrc
for parallel compiler
I think we can just leave it here and merge it when the other work of parallel compilation is done. |
I'm not sure it's worth leaving this open for some undefined period of time. Perf seems good enough to merge if you'd like to do that. Otherwise, I think we should just close it. |
That makes sense. We'd better close it now |
part of #101566
Test perf of
Lrc
and make optimization