Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remap_env_constness in queries #109665

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Mar 27, 2023

This removes some of the complexities with const traits. #88119 used to be caused by this but was fixed by param_env = param_env.without_const().

@rustbot
Copy link
Collaborator

rustbot commented Mar 27, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 27, 2023
@fee1-dead fee1-dead marked this pull request as draft March 27, 2023 15:08
@rust-log-analyzer

This comment has been minimized.

@fee1-dead fee1-dead marked this pull request as ready for review April 16, 2023 08:06
@fee1-dead
Copy link
Member Author

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned b-naber Apr 16, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Apr 16, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 16, 2023

📌 Commit 886c0e6 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2023
…fee1-dead

Rollup of 3 pull requests

Successful merges:

 - rust-lang#109665 (Remove `remap_env_constness` in queries)
 - rust-lang#110345 (Remove `TypeSuper{Foldable,Visitable}` impls for `Region`.)
 - rust-lang#110396 (Use lint via `lint_defs` instead of `lints`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Apr 16, 2023
…, r=oli-obk

Remove `remap_env_constness` in queries

This removes some of the complexities with const traits. rust-lang#88119 used to be caused by this but was fixed by `param_env = param_env.without_const()`.
@bors bors merged commit a5136f1 into rust-lang:master Apr 16, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants