-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove remap_env_constness
in queries
#109665
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Mar 27, 2023
fee1-dead
commented
Mar 27, 2023
This comment has been minimized.
This comment has been minimized.
compiler/rustc_trait_selection/src/traits/query/type_op/prove_predicate.rs
Show resolved
Hide resolved
fee1-dead
force-pushed
the
rm-remap-queries
branch
from
April 8, 2023 09:28
733948f
to
c31629b
Compare
fee1-dead
force-pushed
the
rm-remap-queries
branch
from
April 8, 2023 10:19
c31629b
to
886c0e6
Compare
r? @oli-obk |
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 16, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2023
…fee1-dead Rollup of 3 pull requests Successful merges: - rust-lang#109665 (Remove `remap_env_constness` in queries) - rust-lang#110345 (Remove `TypeSuper{Foldable,Visitable}` impls for `Region`.) - rust-lang#110396 (Use lint via `lint_defs` instead of `lints`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Apr 16, 2023
…, r=oli-obk Remove `remap_env_constness` in queries This removes some of the complexities with const traits. rust-lang#88119 used to be caused by this but was fixed by `param_env = param_env.without_const()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some of the complexities with const traits. #88119 used to be caused by this but was fixed by
param_env = param_env.without_const()
.