-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement stable-wakers RFC #109706
Implement stable-wakers RFC #109706
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Ironically, this PR is getting negative feedback from tidy due to the lack of stability attributes. |
Is writing an arbitrary feature name sufficient? |
This comment has been minimized.
This comment has been minimized.
Yes, you can just pick names out of a hat. |
☔ The latest upstream changes (presumably #110324) made this pull request unmergeable. Please resolve the merge conflicts. |
I believe the way the conversation in rust-lang/rfcs#3404 went suggests this will not be pursued further, please feel free to reopen and rebase (in that order) if I am wrong. |
Implements the ABI-stabilize
core::task::Waker
RFC