-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure.py: add flag for riscv{64,32}gc musl-root #110779
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @albertlarsan68 (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
LGTM |
Why does this need its own flag? why not |
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#110563 (Break up long function in trait selection error reporting + clean up nearby code) - rust-lang#110755 ([LLVM17] Adapt to `ExplicitEmulatedTLS` removal.) - rust-lang#110775 (Update books) - rust-lang#110779 (configure.py: add flag for riscv{64,32}gc musl-root) - rust-lang#110782 (Revert panic oom) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Good idea, thanks! I see this commit as a kind of "compatibility" measure to make it "just works" upstream to avoid the aforementioned prolonged procedures and pains downstream. |
Add the corresponding flag for detecting
--musl-root-riscv64gc
and--musl-root-riscv32gc
with ./configure, which is beneficial for downstream Linux distros to create the rust package with the same "recipe" from other architectures.