Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.py: add flag for riscv{64,32}gc musl-root #110779

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

jchzhou
Copy link

@jchzhou jchzhou commented Apr 24, 2023

Add the corresponding flag for detecting --musl-root-riscv64gc and --musl-root-riscv32gc with ./configure, which is beneficial for downstream Linux distros to create the rust package with the same "recipe" from other architectures.

@rustbot
Copy link
Collaborator

rustbot commented Apr 24, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @albertlarsan68 (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 24, 2023
@albertlarsan68
Copy link
Member

LGTM
Thanks for the PR!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 24, 2023

📌 Commit d2516c1 has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2023
@jyn514
Copy link
Member

jyn514 commented Apr 24, 2023

Why does this need its own flag? why not ./configure --set target.riscv64gc.musl-root=/foo?

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 25, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#110563 (Break up long function in trait selection error reporting + clean up nearby code)
 - rust-lang#110755 ([LLVM17] Adapt to `ExplicitEmulatedTLS` removal.)
 - rust-lang#110775 (Update books)
 - rust-lang#110779 (configure.py: add flag for riscv{64,32}gc musl-root)
 - rust-lang#110782 (Revert panic oom)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2212354 into rust-lang:master Apr 25, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 25, 2023
@jchzhou
Copy link
Author

jchzhou commented Apr 25, 2023

Why does this need its own flag? why not ./configure --set target.riscv64gc.musl-root=/foo?

Good idea, thanks!
To implement that, though, I either need to change the original "recipe" from other architectures that --musl-root-ARCH works fine (which means extra steps of review by each affected arch's maintainers and days of overhead) or add an if on RISC-V, then do this way conditional, which is less elegant.

I see this commit as a kind of "compatibility" measure to make it "just works" upstream to avoid the aforementioned prolonged procedures and pains downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants