-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not build docs in try builds #111660
Do not build docs in try builds #111660
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 5581afaeeec8008779fb33cd1343736ee5416bd2 with merge 2df3488ee81cdb91971e0c40ced4264dfd2fa873... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (2df3488ee81cdb91971e0c40ced4264dfd2fa873): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 644.057s -> 645.098s (0.16%) |
@bors try |
⌛ Trying commit 33ff1be7382168b0a90f2c8b02cb12400fc2ebd0 with merge 9831f73112693bcff7b9706bc7d94cdb3a62e827... |
☀️ Try build successful - checks-actions |
Hmm, this build took just 1h 35minutes, which is quite fast, but it was caused by something else (quick CI runner?), because everything was fast. The documentation is still being built. |
@bors try |
⌛ Trying commit 3a1e44dd01882467acdce05e53bbef7dfca74d1a with merge 22dc5ccf43279db086b7c9e2879e602d6f1da6c8... |
☀️ Try build successful - checks-actions |
@rust-timer build 22dc5ccf43279db086b7c9e2879e602d6f1da6c8 |
This comment has been minimized.
This comment has been minimized.
3a1e44d
to
460f403
Compare
This is now ready for review. |
Finished benchmarking commit (22dc5ccf43279db086b7c9e2879e602d6f1da6c8): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 643.044s -> 643.294s (0.04%) |
Perf can run without the missing components, good. |
This makes it a little harder for us to produce e.g. dev-static artifacts for testing. I wonder if that's the right tradeoff to make, for a relatively small gain on try build times. I guess putting the doc builds into an entirely new builder is going to be very slow, since it needs to build a bunch of dependencies? cc @rust-lang/infra if you have thoughts. I think I'm inclined to go ahead with this (r=me in 1 week). |
☀️ Try build successful - checks-actions |
1 similar comment
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
a612e69
to
db113b1
Compare
@bors try |
⌛ Trying commit db113b1 with merge 281576a7fc7c62e208d0c5aa742bf9259b928ee2... |
☀️ Try build successful - checks-actions |
@rust-timer build 281576a7fc7c62e208d0c5aa742bf9259b928ee2 Checking if the latest change didn't break perfbot again. |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (281576a7fc7c62e208d0c5aa742bf9259b928ee2): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 642.933s -> 643.494s (0.09%) |
@bors r=mark-simulacrum |
☀️ Test successful - checks-actions |
Finished benchmarking commit (d59363a): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 645.554s -> 643.493s (-0.32%) |
Hmm, I was worried for a while that the try build optimization was propagated into dist builds, but it does not seem like so, the dist build compiled all the artifacts. It's super weird though, where do the perf. changes come from :/ |
This PR adds a new environment variable to the optimized build Python script, which causes it to ignore certain parts of the final
dist
build (mainly docs) in try builds. This reduces the duration of try builds by ~10 minutes.