Don't mention already-set fields in struct constructor missing field error #112323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
compiler-errors
commented
Jun 5, 2023
| @@ -3,6 +3,8 @@ error[E0559]: variant `Option<_>::None` has no field named `value` | |||
| | | |||
| LL | None { value: (), ..Default::default() }.await; | |||
| | ^^^^^ `Option<_>::None` does not have this field | |||
| | | |||
| = note: all struct fields are already assigned | |||
There was a problem hiding this comment.
perhaps this could be a span-suggestion to remove the field altogether, but honestly I'm fine with just letting the programmer decide what to do with this
There was a problem hiding this comment.
I think making a suggestion would be better, but it's fine as-is
WaffleLapkin
approved these changes
Jun 8, 2023
| @@ -3,6 +3,8 @@ error[E0559]: variant `Option<_>::None` has no field named `value` | |||
| | | |||
| LL | None { value: (), ..Default::default() }.await; | |||
| | ^^^^^ `Option<_>::None` does not have this field | |||
| | | |||
| = note: all struct fields are already assigned | |||
There was a problem hiding this comment.
I think making a suggestion would be better, but it's fine as-is
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 9, 2023
…ields, r=WaffleLapkin Don't mention already-set fields in struct constructor missing field error Fixes rust-lang#111149
This was referenced Jun 9, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 9, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#112323 (Don't mention already-set fields in struct constructor missing field error) - rust-lang#112395 (Add Terminator::InlineAsm conversion from MIR to SMIR) - rust-lang#112411 (add programmerjake to portable-simd cc list) - rust-lang#112428 (Structurally resolve pointee in `check_pat_lit`) - rust-lang#112444 (Don't debug-print `Interned` or `PrivateZst`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111149