Rollup of 8 pull requests #113460
Closed
Rollup of 8 pull requests #113460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d or expose the private item directly
Comments out the C string literals due to rust-lang#113334 Fixes rust-lang/rust-clippy#11121
…new-solver, r=lcnr Reveal opaques in new solver We were testing against the wrong reveal mode 😨 Also a couple of misc commits that I don't want to really put in separate prs r? ```@lcnr```
…ath, r=notriddle,fmease [rustdoc] If re-export is private, get the next item until a public one is found or expose the private item directly Fixes rust-lang#81141. If we have: ```rust use Private as Something; pub fn foo() -> Something {} ``` Then `Something` will be replaced by `Private`. r? ```@notriddle```
…at-again, r=oli-obk Structurally normalize again for byte string lit pat checking We need to structurally normalize the pointee of a match scrutinee when trying to match byte string patterns -- we used[^1] to call `structurally_resolve_type`, which errors for type vars[^2], but lcnr added `try_structurally_resolve_type`[^3] in the mean time, which is the right thing to use here since it's totally opportunistic. Fixes rust-lang/trait-system-refactor-initiative#38 [^1]: rust-lang#112428 [^2]: rust-lang#112993 [^3]: rust-lang#113086
…, r=albertlarsan68 Add needs-triage to all new issues Closes rust-lang#113261 The label: https://github.com/rust-lang/rust/labels/needs-triage
…itit-gat, r=spastorino Remove `variances_of` on RPITIT GATs, remove its one use-case It doesn't make sense to implement variances on a GAT anyways, since we don't relate GATs with variance: https://github.com/rust-lang/rust/blob/85bf07972a1041b9e25393b803d0e006bec3eaaf/compiler/rustc_middle/src/ty/relate.rs#L569-L579 r? `@spastorino`
miri: check that assignments do not self-overlap r? ```@oli-obk```
…er-errors Remove from_method symbol Fixes rust-lang#113439 `on_unimplemented_note` was calling `item_name` for RPITITs and that produced ICEs. I've added a regression test for that but also have removed `from_method` symbol entirely because it wasn't even used and by doing that the `item_name` call was also removed. r? `@compiler-errors`
Fix failing clippy tests Comments out the C string literals due to rust-lang#113334 Fixes rust-lang/rust-clippy#11121 Opened against `rust-lang/rust` in order to unblock rust-lang#113450 r? ``@Nilstrieb``
rustbot
added
A-meta
|
@bors r+ p=25 rollup=never |
bors
added
S-waiting-on-bors
|
⌛ Testing commit d8f0b1f with merge 56257caec947bf2efd853cc2ed99b7e38f96b216... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
⌛ Testing commit d8f0b1f with merge a9836d4907e242f74d21a04a3c9ed6663dcc4411... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
variances_ofon RPITIT GATs, remove its one use-case #113427 (Removevariances_ofon RPITIT GATs, remove its one use-case)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup