-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #113468
Closed
Closed
Rollup of 8 pull requests #113468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's nicer this way.
It's needless verbosity.
…d or expose the private item directly
…ath, r=notriddle,fmease [rustdoc] If re-export is private, get the next item until a public one is found or expose the private item directly Fixes rust-lang#81141. If we have: ```rust use Private as Something; pub fn foo() -> Something {} ``` Then `Something` will be replaced by `Private`. r? ````@notriddle````
CGU formation tweaks Minor improvements I found while trying out something bigger that didn't work out. r? `@wesleywiser`
…, r=albertlarsan68 Add needs-triage to all new issues Closes rust-lang#113261 The label: https://github.com/rust-lang/rust/labels/needs-triage
miri: check that assignments do not self-overlap r? ````@oli-obk````
…er-errors Remove unused from_method from rustc_on_unimplemented Fixes rust-lang#113439 `on_unimplemented_note` was calling `item_name` for RPITITs and that produced ICEs. I've added a regression test for that but also have removed `from_method` symbol entirely because it wasn't even used and by doing that the `item_name` call was also removed. r? `@compiler-errors`
…er-errors Avoid calling report_forbidden_specialization for RPITITs Fixes rust-lang#113438 r? `@compiler-errors`
Update cargo 1 commits in 5b377cece0e0dd0af686cf53ce4637d5d85c2a10..45782b6b8afd1da042d45c2daeec9c0744f72cc7 2023-06-30 00:01:00 +0000 to 2023-07-05 16:54:51 +0000 - docs(ref): Provide guidance on version requirements (rust-lang/cargo#12323) r? `@ghost`
Fix comment of `fn_can_unwind` Reopen of rust-lang#113213
@bors r+ rollup=never p=8 |
⌛ Testing commit c5563b8 with merge d19c89b11f30f4dbf24ba3461007b569f8662362... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
⌛ Testing commit c5563b8 with merge 835111fd97643f8a4d1c700e7a6f1db1ebfda05e... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-meta
Area: Issues & PRs about the rust-lang/rust repository itself
rollup
A PR which is a rollup
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
fn_can_unwind
#113467 (Fix comment offn_can_unwind
)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup