Two codegen fixes #113775
Closed
Two codegen fixes #113775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR rust-lang#112946 tweaked the naming of LLVM threads, but messed things up slightly, resulting in threads on Windows having names like `optimize module {} regex.f10ba03eb5ec7975-cgu.0`. This commit removes the extraneous `{} `.
rustbot
added
S-waiting-on-review
bjorn3
reviewed
Jul 19, 2023
| @@ -36,10 +34,6 @@ pub struct PerLocalVarDebugInfo<'tcx, D> { | |||
| /// `DIVariable` returned by `create_dbg_var`. | |||
| pub dbg_var: Option<D>, | |||
|
|
|||
| /// Byte range in the `dbg_var` covered by this fragment, | |||
| /// if this is a fragment of a composite `VarDebugInfo`. | |||
| pub fragment: Option<Range<Size>>, | |||
There was a problem hiding this comment.
I think this field actually needs to be used to produce correct debuginfo for composite debuginfo variables.
wesleywiser
reviewed
Jul 21, 2023
| // DWARF is concerned, it's not really a fragment. | ||
| None | ||
| } else { | ||
| Some(fragment_start..fragment_start + fragment_layout.size) |
There was a problem hiding this comment.
This codepath is taken if the MIR SROA pass is enabled.
|
I have moved the "Fix LLVM thread names on Windows" commit to #113879. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of small things.
r? @wesleywiser