Remove conditional use of Sharded from query caches

[Zoxc]

Sharded is already a zero cost abstraction, so it shouldn't affect the performance of the single thread compiler if LLVM does its job.

r? @cjgillot

[cjgillot]

@bors try @rust-timer queue

[bors]

⌛ Trying commit a4e55f1 with merge 1d57dc82a0252cde29c9d98926cdf258b23692cb...

[bors]

☀️ Try build successful - checks-actions
Build commit: 1d57dc82a0252cde29c9d98926cdf258b23692cb (1d57dc82a0252cde29c9d98926cdf258b23692cb)

[rust-timer]

Finished benchmarking commit (1d57dc82a0252cde29c9d98926cdf258b23692cb): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.4%, 0.7%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.6%	[-0.8%, -0.5%]	4
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.1%	[1.2%, 8.6%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 635.223s -> 636.443s (0.19%)
Artifact size: 346.78 MiB -> 347.43 MiB (0.19%)

[cjgillot]

Perf is a wash, and this simplifies a lot of code.
@bors r+

[bors]

📌 Commit a4e55f1 has been approved by cjgillot

It is now in the queue for this repository.

[bors]

⌛ Testing commit a4e55f1 with merge c5833f1...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing c5833f1 to master...

[rust-timer]

Finished benchmarking commit (c5833f1): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 0.5%]	3
Regressions ❌ (secondary)	0.5%	[0.4%, 0.6%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.2%, 0.5%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.4%	[-2.8%, -2.0%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.4%	[-2.8%, -2.0%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.126s -> 634.855s (0.43%)
Artifact size: 346.51 MiB -> 346.99 MiB (0.14%)