-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more information to error message for unconstrained_parameter E0207 #115245
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I think the note here is not super helpful. I would probably just start with the changes in #108252 and address the review comments there. Then I can review that! |
Should I directly transition to a structured error as mentioned in #108252 ? |
Up to you :) happy to split it into parts |
@jackh726 any updates? |
The job Click to see the possible cause of the failure (guessed by this bot)
|
Sorry for the delay, I am now starting to pick this issue up again. If there are some more concrete ideas / examples on how the error should look exactly, I am happy to hear them as the discussion on the previous PR was not very conclusive (i think) and mentions a variety of ideas and potential things |
☔ The latest upstream changes (presumably #119751) made this pull request unmergeable. Please resolve the merge conflicts. |
Thinking about this more, I wonder if it's worth distinguishing unused vs unconstrained here? Completely unused is easy (just remove), but unconstrained is harder (because it may still be used, and we don't know the best way to fix it, see #64155 for an example). |
In the unused case, we can suggest removing (with suggested change). In the unconstrained case, we can just note the requirements to make it constrained. |
@Lol3rrr any updates on this? thanks |
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this. @rustbot label: +S-inactive |
Fixes #107295 and also takes inspiration from a previously attempted PR #108252