Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a now-unnecessary check for generators. #115763

Closed
wants to merge 3 commits into from
Closed

Remove a now-unnecessary check for generators. #115763

wants to merge 3 commits into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Sep 11, 2023

There should be no cycles from the mir opt pipeline to generators, but not revealing and normalizing in generators may cause us to fix bugs with revealing and normalizing that will then still occur in async code.

r? @cjgillot

thanks @compiler-errors for the idea

@oli-obk
Ignore ICE dumps
aad707d
@oli-obk
Fix rustfmt path in default vscode settings.json
9597d24 
The r-a vscode extension has started `cd`-ing into the current crate's root directory, and then invoking rustfmt. But our rustfmt path is relative, and was then not available.
@oli-obk
Remove a now-unnecessary check for generators.
07782ed 
There should be no cycles from the mir opt pipeline to generators, but not revealing and normalizing in generators may cause us to fix bugs with revealing and normalizing that will then still occur in async code.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 11, 2023
@rustbot
Copy link
Collaborator

rustbot commented Sep 11, 2023

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@oli-obk oli-obk mentioned this pull request Sep 11, 2023
Merged
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-15 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
...............................F

failures:

---- setup::tests::check_matching_settings_hash stdout ----
thread 'setup::tests::check_matching_settings_hash' panicked at setup/tests.rs:9:5:
assertion `left == right` failed: Update `SETTINGS_HASHES` with the new hash of `src/etc/rust_analyzer_settings.json`
  left: "ff705f15d76357e2b7c98d6ed9983ac63acde9f1fbf58d10528c00df1d86d554"
 right: "47d227f424bf889b0d899b9cc992d5695e1b78c406e183cd78eafefbe5488923"

failures:
error: test failed, to rerun pass `--lib`
    setup::tests::check_matching_settings_hash

@cjgillot
Copy link
Contributor

r=me with CI fixed.

@cjgillot cjgillot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2023
@oli-obk
Copy link
Contributor Author

oli-obk commented Oct 23, 2023

This has since landed as part of #115759

@oli-obk oli-obk closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oli-obk @rustbot @rust-log-analyzer @cjgillot