-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uplift mutability to rustc_type_ir
#116919
Conversation
Some changes occurred in need_type_info.rs cc @lcnr This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes might have occurred in exhaustiveness checking cc @Nadrieril Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
wait I definitely didn't check if this passed clippy or rustdoc @rustbot author |
This comment has been minimized.
This comment has been minimized.
Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in src/librustdoc/clean/types.rs cc @camelid |
@rustbot ready |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
12225f0
to
da1787b
Compare
The Miri subtree was changed cc @rust-lang/miri |
da1787b
to
32d79bb
Compare
☔ The latest upstream changes (presumably #116923) made this pull request unmergeable. Please resolve the merge conflicts. |
Part of rust-lang/types-team#124
I'm less satisfied with this one compared to #116918 -- namely, there are a few places (other than astconv itself) that we have to shunt between
hir::Mutability
andty::Mutability
. Maybe we should have a trait inrustc_middle
to convert between them?r? types