-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make let_binding_suggestion
more reasonable
#117934
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks ok. However, I can't approve this PR since I'm only a rustdoc reviewer :')
This comment has been minimized.
This comment has been minimized.
r=me after addressing #117934 (comment), #117934 (comment) and squashing commits. |
@rustbot ready |
Thanks! |
☀️ Test successful - checks-actions |
Finished benchmarking commit (4fd68eb): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 674.644s -> 677.24s (0.38%) |
Great,thanks @petrochenkov and @fmease for patient review 😁 |
This is my first PR for rustc, which trying to fix #117894, I am not familiar with some internal api so maybe some modification here isn't the way to go, appreciated for any review suggestion.