-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clippy::needless_borrow
in the compiler
#118143
Conversation
`x clippy compiler -Aclippy::all -Wclippy::needless_borrow --fix`. Then I had to remove a few unnecessary parens and muts that were exposed now.
@@ -34,7 +34,7 @@ pub(super) fn generate_invalidates<'tcx>( | |||
borrow_set, | |||
tcx, | |||
location_table, | |||
body: &body, | |||
body: body, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there will probably quite some of those - I will not fix them here
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred in cc @BoxyUwU Some changes might have occurred in exhaustiveness checking cc @Nadrieril Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor This PR changes Stable MIR cc @oli-obk, @celinval, @spastorino, @ouz-a Some changes occurred in engine.rs, potentially modifying the public API of Some changes occurred in need_type_info.rs cc @lcnr Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
good to go! |
I verified this by reproducing the command above and comparing the output. @bors r+ p=10 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (fec80b4): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 679.348s -> 675.654s (-0.54%) |
x clippy compiler -Aclippy::all -Wclippy::needless_borrow --fix
.Then I had to remove a few unnecessary parens and muts that were exposed now.
r? @compiler-errors you told me you want to review this
I will do a self review first (which, for this, is easiest on GitHub once the PR is open) - did it