-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
always run configure_linker
except for mir-opt tests
#120803
Conversation
`configure_linker` now runs consistently unless it's for mir-opt tests. Previously `!= "check"` condition was causing dirt in the cargo cache between runs of `x anything-but-not-check` and `x check` Signed-off-by: onur-ozkan <[email protected]>
rustbot has assigned @Mark-Simulacrum. Use r? to explicitly pick a reviewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried this out and it seems to work.
I'd love to see a cleaner signature for Builder::cargo
in the future, but I'm happy to see any fix for this so quickly. Thanks!
This is definetly on my to-do plans. |
Seems too easy now to just forget calling |
f094467
to
3c019de
Compare
We don't do this anymore. |
3c019de
to
97db15d
Compare
Signed-off-by: onur-ozkan <[email protected]>
97db15d
to
ff6d296
Compare
The approach makes sense to me, sadly I can't confidently review bootstrap changes. @rust-lang/bootstrap would be good to land this rather quickly, this is fixing an issue that currently extends the edit-compile-test cycle for some cases from <1s to >1min. |
@bors r+ rollup=iffy |
This is fixing a rustc development roadblock. |
☀️ Test successful - checks-actions |
Finished benchmarking commit (1a648b3): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 664.94s -> 664.283s (-0.10%) |
configure_linker
now runs consistently unless it's for mir-opt tests. Previously!= "check"
condition was causing dirt in the cargo cache between runs ofx anything-but-not-check
andx check
.Fixes #120768
cc @saethlin