-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtree update of rustc_codegen_gcc
#121390
Closed
GuillaumeGomez
wants to merge
219
commits into
rust-lang:master
from
GuillaumeGomez:subtree-update_cg_gcc_2024-02-21
Closed
Subtree update of rustc_codegen_gcc
#121390
GuillaumeGomez
wants to merge
219
commits into
rust-lang:master
from
GuillaumeGomez:subtree-update_cg_gcc_2024-02-21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update_cg_gcc_2023-11-17
…1_21 Sync from rust 2023/11/21
The `fluent_messages!` macro produces uses of `crate::{D,Subd}iagnosticMessage`, which means that every crate using the macro must have this import: ``` use rustc_errors::{DiagnosticMessage, SubdiagnosticMessage}; ``` This commit changes the macro to instead use `rustc_errors::{D,Subd}iagnosticMessage`, which avoids the need for the imports.
Currently we always do this: ``` use rustc_fluent_macro::fluent_messages; ... fluent_messages! { "./example.ftl" } ``` But there is no need, we can just do this everywhere: ``` rustc_fluent_macro::fluent_messages! { "./example.ftl" } ``` which is shorter.
Implements lane-local byte swapping through vector shuffles. While this is more setup than non-vector shuffles, this implementation can shuffle multiple integers concurrently. Signed-off-by: Andy Sadler <[email protected]>
Signed-off-by: Andy Sadler <[email protected]>
The simd intrinsic handler was delegating implementation of `simd_frem` to `Builder::frem`, which wasn't able to handle vector-typed inputs. To fix this, teach this method how to handle vector inputs. Signed-off-by: Andy Sadler <[email protected]>
If we're running against a patched libgccjit, use an algorithm similar to what LLVM uses for this intrinsic. Otherwise, fallback to a per-element bitreverse. Signed-off-by: Andy Sadler <[email protected]>
Signed-off-by: Andy Sadler <[email protected]>
gcc_not would panic upon encountering a vector type, which is not what we want here. Signed-off-by: Andy Sadler <[email protected]>
This test now passes when tested with a patched libgccjit. However, due to [some compiler bugs][1], we can't enable this for non-patched libgccjit yet. [1]: https://github.com/sadlerap/rustc_codegen_gcc/actions/runs/6820180639/job/18548672444#step:15:4375 Signed-off-by: Andy Sadler <[email protected]>
…ctions Fix build instructions
`sess` is a terribly misleading name for a `Handler`! This confused me for a bit.
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
subtree-update_cg_gcc_2024-02-21
branch
from
March 2, 2024 17:06
0024930
to
812c1f8
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
subtree-update_cg_gcc_2024-02-21
branch
from
March 2, 2024 17:11
812c1f8
to
b0b8940
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
subtree-update_cg_gcc_2024-02-21
branch
from
March 2, 2024 17:24
b0b8940
to
9e40b1c
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
subtree-update_cg_gcc_2024-02-21
branch
from
March 2, 2024 19:36
9e40b1c
to
1419e70
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
subtree-update_cg_gcc_2024-02-21
branch
from
March 2, 2024 19:42
1419e70
to
ccd0e7d
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
subtree-update_cg_gcc_2024-02-21
branch
from
March 3, 2024 15:02
ccd0e7d
to
a4c1195
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
subtree-update_cg_gcc_2024-02-21
branch
from
March 3, 2024 15:26
a4c1195
to
31789e5
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
subtree-update_cg_gcc_2024-02-21
branch
from
March 3, 2024 15:39
31789e5
to
391bb9c
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
subtree-update_cg_gcc_2024-02-21
branch
from
March 3, 2024 15:43
391bb9c
to
3567f84
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
subtree-update_cg_gcc_2024-02-21
branch
2 times, most recently
from
March 3, 2024 22:01
6c43bce
to
800737c
Compare
☔ The latest upstream changes (presumably #121665) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
subtree-update_cg_gcc_2024-02-21
branch
from
March 4, 2024 14:30
800737c
to
bda09e1
Compare
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 10, 2024
…_2024-03-05, r=MarkSimulacrum Subtree update cg gcc 2024 03 05 Reopening of rust-lang#121390. r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.