Change only_local to a enum type. #122695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @petrochenkov. Use r? to explicitly pick a reviewer |
rustbot
added
S-waiting-on-review
|
you need to rebase to the newest master branch |
surechen
force-pushed
the
make_only_local_explict_argument
branch
from
5673e6a to
950ea97
Compare
Done. Thank you. |
|
Can we invert it and call it |
Agreed, |
surechen
force-pushed
the
make_only_local_explict_argument
branch
from
950ea97 to
c941fa4
Compare
This comment has been minimized.
This comment has been minimized.
lcnr
reviewed
Mar 19, 2024
lcnr
reviewed
Mar 19, 2024
surechen
force-pushed
the
make_only_local_explict_argument
branch
from
c941fa4 to
a0d7715
Compare
…e a variant of that enum.
surechen
force-pushed
the
make_only_local_explict_argument
branch
from
a0d7715 to
db48dfc
Compare
|
thanks @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 19, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#122435 (Don't trigger `unused_qualifications` on global paths) - rust-lang#122556 (Extend format arg help for simple tuple index access expression) - rust-lang#122634 (compiletest: Add support for `//@ aux-bin: foo.rs`) - rust-lang#122677 (Fix incorrect mutable suggestion information for binding in ref pattern.) - rust-lang#122691 (Fix ICE: `global_asm!()` Don't Panic When Unable to Evaluate Constant) - rust-lang#122695 (Change only_local to a enum type.) - rust-lang#122717 (Ensure stack before parsing dot-or-call) - rust-lang#122719 (Ensure nested statics have a HIR node to prevent various queries from ICEing) - rust-lang#122720 ([doc]:fix error code example) - rust-lang#122724 (add test for casting pointer to union with unsized tail) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 19, 2024
Rollup merge of rust-lang#122695 - surechen:make_only_local_explict_argument, r=lcnr Change only_local to a enum type. Change only_local to enum type and change the macros to always require a variant of that enum. r? `@lcnr`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change only_local to enum type and change the macros to always require a variant of that enum.
r? @lcnr