Ensure we do not accidentally insert new early aborts in the analysis passes #123631
Conversation
rustbot
added
S-waiting-on-review
|
Makes a lot of sense. Feel free to r=me after CI is green. |
|
@bors r=jieyouxu welcome to the team! |
bors
added
S-waiting-on-bors
| fn analysis(tcx: TyCtxt<'_>, (): ()) -> Result<()> { | ||
| run_required_analyses(tcx); | ||
|
|
||
| let sess = tcx.sess; |
There was a problem hiding this comment.
Should the other 2 blocks in this function be named too? Like run_extra_analyses and record_vtable_sizes?
There was a problem hiding this comment.
Yea, I was thinking the same thing, but didn't want to do it in this PR
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (2805aed): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 672.151s -> 672.546s (0.06%) |
pulling the infallible part out into a separate function makes sure that someone needs to change the signature in order to regress this.
We only want to stop compilation in the presence of errors after all analyses are done, but before we start running lints.
per-item we can still stop doing work if previous queries returned errors, but that's a separate story.