Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing Scalar::from_i128 #126157

Merged
merged 1 commit into from
Jun 8, 2024
Merged

add missing Scalar::from_i128 #126157

merged 1 commit into from
Jun 8, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jun 8, 2024

We seem to have from methods for all primitive types except i128... let's complete the set of methods. (This came up in rust-lang/miri#3622.)

@rustbot
Copy link
Collaborator

rustbot commented Jun 8, 2024

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 8, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jun 8, 2024

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@RalfJung RalfJung mentioned this pull request Jun 8, 2024
Merged
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 8, 2024

📌 Commit e26e42f has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 8, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 8, 2024
@bors
Auto merge of rust-lang#126167 - matthiaskrgr:rollup-r717w0s, r=matth…
565cadb 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#126132 (config.example.toml: minor improves)
 - rust-lang#126149 (Miri std tests: don't set BOOTSTRAP_SKIP_TARGET_SANITY unnecessarily)
 - rust-lang#126157 (add missing Scalar::from_i128)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7fd9b1f into rust-lang:master Jun 8, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 8, 2024
@rust-timer
Unrolled build for rust-lang#126157
b1a72c0 
Rollup merge of rust-lang#126157 - RalfJung:scalar-i128, r=compiler-errors

add missing Scalar::from_i128

We seem to have `from` methods for all primitive types except `i128`... let's complete the set of methods. (This came up in rust-lang/miri#3622.)
@rustbot rustbot added this to the 1.81.0 milestone Jun 8, 2024
@RalfJung RalfJung deleted the scalar-i128 branch June 8, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @rustbot @compiler-errors @bors @davidtwco