-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #126434
Closed
Closed
Rollup of 9 pull requests #126434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the ValuePairs glob import - Make DummyPairs -> ValuePairs::Dummy and make it bug more - Fix WC - Make interner return `impl IntoIterator`s
Miri no longer respects `MIRI_SYSROOT` and wants to be treated like a REAL rustc, with `--sysroot`. *pats Miri* sure Miri, just for you :3.
…ontext -> CompileTimeInterpCx to match the terms used in the shared interpreter infrastructure
…rieb Clarify `Command::new` behavior for programs with arguments I mistakenly passed program path along arguments as the same string into `Command::new` a couple of times now. It might be useful to explicitly highlight that `Command::new` intends to accept path to a program, not path to a program plus arguments. Also nudge the user to use `Command::arg` or `Command::args` if they wish to pass arguments.
Fix Miri sysroot for `x run` Miri no longer (after rust-lang/miri#3411) respects `MIRI_SYSROOT` and wants to be treated like a REAL rustc, with `--sysroot`. \*pats Miri\* sure Miri, just for you :3. fixes rust-lang#126233 r? RalfJung (or whoever else feels like it)
…nst_fn_mir, r=jieyouxu Migrate run make const fn mir Part of rust-lang#121876. r? `@jieyouxu`
…traits, r=lcnr Uplift `structural_traits.rs` into the new trait solver Self-explanatory. I will leave some comments inline regarding design decisions.
…low-non-lint-warnings-cmdline, r=jieyouxu Migrate `run-make/allow-non-lint-warnings-cmdline` to `rmake.rs` Part of rust-lang#121876. r? `@jieyouxu`
…oli-obk const-eval: make lint scope computation consistent The first commit is some renaming for consistency, but otherwise unrelated. It just didn't feel worth a separate PR, but I can split this up if you prefer. r? `@oli-obk`
Fix wording in {checked_}next_power_of_two Small documentation update
…, r=scottmcm Small style improvement in `gvn.rs` Allowed by rust-lang#110451 (comment). :P r? `@scottmcm`
…copy, r=Nilstrieb Fix wrong `assert_unsafe_precondition` message for `core::ptr::copy` A small fix in the `assert_unsafe_precondition` message for `core::ptr::copy` as described by rust-lang#126400 . fixes rust-lang#126400
rustbot
added
A-run-make
Area: port run-make Makefiles to rmake.rs
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 13, 2024
rustbot
added
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
WG-trait-system-refactor
The Rustc Trait System Refactor Initiative (-Znext-solver)
rollup
A PR which is a rollup
labels
Jun 13, 2024
@bors r+ rollup=never p=9 |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 13, 2024
The job Click to see the possible cause of the failure (guessed by this bot)
|
The PR CI failure is not due to this PR, but the spurious #126430 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-run-make
Area: port run-make Makefiles to rmake.rs
A-testsuite
Area: The testsuite used to check the correctness of rustc
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
WG-trait-system-refactor
The Rustc Trait System Refactor Initiative (-Znext-solver)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Command::new
behavior for programs with arguments #123726 (ClarifyCommand::new
behavior for programs with arguments)x run
#126238 (Fix Miri sysroot forx run
)structural_traits.rs
into the new trait solver #126360 (Upliftstructural_traits.rs
into the new trait solver)run-make/allow-non-lint-warnings-cmdline
tormake.rs
#126386 (Migraterun-make/allow-non-lint-warnings-cmdline
tormake.rs
)gvn.rs
#126392 (Small style improvement ingvn.rs
)assert_unsafe_precondition
message forcore::ptr::copy
#126402 (Fix wrongassert_unsafe_precondition
message forcore::ptr::copy
)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup