Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate staticlib-blank-lib, rlib-format-packed-bundled-libs-3 and issue-97463-abi-param-passing run-make tests to rmake #127778

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Migrate staticlib-blank-lib, rlib-format-packed-bundled-libs-3 and issue-97463-abi-param-passing run-make tests to rmake #127778

merged 3 commits into from
Jul 23, 2024

Conversation

Oneirical
Copy link
Contributor

@Oneirical Oneirical commented Jul 15, 2024 •
edited by jieyouxu
Loading

Part of #121876 and the associated Google Summer of Code project.

Please try:

try-job: aarch64-gnu
try-job: armhf-gnu
try-job: test-various
try-job: x86_64-mingw
try-job: x86_64-msvc
try-job: x86_64-gnu-llvm-18

@rustbot
Copy link
Collaborator

rustbot commented Jul 15, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 15, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 15, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

The run-make-support library was changed

cc @jieyouxu

@Oneirical
Copy link
Contributor Author

@rustbot blocked #126208

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2024
@jieyouxu jieyouxu mentioned this pull request Jul 16, 2024
Open
@jieyouxu
Copy link
Member

@rustbot author (linked pr waa merged)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jul 17, 2024
@bors
Copy link
Contributor

bors commented Jul 17, 2024

☔ The latest upstream changes (presumably #127760) made this pull request unmergeable. Please resolve the merge conflicts.

@Oneirical Oneirical force-pushed the artificial-intestlligence branch 3 times, most recently from a117ab7 to 6b3b3ea Compare July 18, 2024 13:33
@Oneirical Oneirical force-pushed the artificial-intestlligence branch from 6b3b3ea to c01e8cd Compare July 18, 2024 13:35
@Oneirical
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2024
@jieyouxu
Copy link
Member

@bors try

@bors
Copy link
Contributor

bors commented Jul 19, 2024

⌛ Trying commit c01e8cd with merge 8f106b3...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 19, 2024
@bors
Auto merge of rust-lang#127778 - Oneirical:artificial-intestlligence,…
8f106b3 
… r=<try>

Migrate `staticlib-blank-lib`, `rlib-format-packed-bundled-libs-3` and `issue-97463-abi-param-passing` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Please try:

try-job: test-various
try-job: x86-64-msvc
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu
Copy link
Member

@bors try

@Oneirical Oneirical force-pushed the artificial-intestlligence branch from 5fc67f9 to 3fb0cd2 Compare July 22, 2024 14:54
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical Oneirical force-pushed the artificial-intestlligence branch from 3fb0cd2 to e1c76b2 Compare July 22, 2024 15:55
@rust-log-analyzer

This comment has been minimized.

Sign in to view
jieyouxu
jieyouxu requested changes Jul 22, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the test should not be able to pass CI AFAICT

tests/run-make/zero-extend-abi-param-passing/rmake.rs Outdated Show resolved Hide resolved
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2024
@jieyouxu
Copy link
Member

Oops I was reviewing while it failed

@Oneirical Oneirical force-pushed the artificial-intestlligence branch from e1c76b2 to 55dda5d Compare July 22, 2024 17:05
@Oneirical
Copy link
Contributor Author

Oneirical commented Jul 22, 2024 •
edited
Loading

Oops I was reviewing while it failed

My bad, I pinged review thinking the change was trivial enough to not test locally. Foolish!

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2024
@jieyouxu
Copy link
Member

@bors try

@bors
Copy link
Contributor

bors commented Jul 22, 2024

⌛ Trying commit 55dda5d with merge b1e3f51...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 22, 2024
@bors
Auto merge of rust-lang#127778 - Oneirical:artificial-intestlligence,…
b1e3f51 
… r=<try>

Migrate `staticlib-blank-lib`, `rlib-format-packed-bundled-libs-3` and `issue-97463-abi-param-passing` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Please try:

try-job: aarch64-gnu
try-job: armhf-gnu
try-job: test-various
try-job: x86_64-mingw
try-job: x86_64-msvc
try-job: x86_64-gnu-llvm-18
@bors
Copy link
Contributor

bors commented Jul 22, 2024

☀️ Try build successful - checks-actions
Build commit: b1e3f51 (b1e3f5134e8b4649fb42c796091a1972cc18ba2c)

jieyouxu
jieyouxu approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

@bors r+ rollup=iffy (abi-related, llvm-ar, cc)

@bors
Copy link
Contributor

bors commented Jul 22, 2024

📌 Commit 55dda5d has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2024
@bors
Copy link
Contributor

bors commented Jul 23, 2024

⌛ Testing commit 55dda5d with merge 8ded134...

@bors
Copy link
Contributor

bors commented Jul 23, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 8ded134 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 23, 2024
@bors bors merged commit 8ded134 into rust-lang:master Jul 23, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Jul 23, 2024
This was referenced Jul 23, 2024
Merged
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8ded134): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 7.3% [7.3%, 7.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary 5.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 5.6% [5.6%, 5.6%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 770.458s -> 770.647s (0.02%)
Artifact size: 328.76 MiB -> 328.81 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbstj fbstj fbstj left review comments

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
Oxidizing run-make tests
Status: Done
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Oneirical @rustbot @jieyouxu @bors @rust-log-analyzer @rust-timer @fbstj