Change orphan hint from "only" to "any uncovered type inside..." #128391

cafce25 · 2024-07-30T12:56:42Z

rustbot · 2024-07-30T12:56:50Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @spastorino (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

cafce25 · 2024-07-30T15:59:12Z

Argh, forgot the patch to the tests, will be home soon and add that.

@rustbot author

cafce25 · 2024-07-30T18:47:30Z

@rustbot review

lcnr · 2024-07-31T09:11:09Z

compiler/rustc_hir_analysis/messages.ftl

@@ -351,7 +351,7 @@ hir_analysis_only_current_traits_arbitrary = only traits defined in the current

 hir_analysis_only_current_traits_foreign = this is not defined in the current crate because this is a foreign trait

-hir_analysis_only_current_traits_label = impl doesn't use only types from inside the current crate
+hir_analysis_only_current_traits_label = impl doesn't use any uncovered types from inside the current crate


this is also not quite correct

the requirement is that given an impl impl<T0..TN> Trait<P1..Pn> for P0, there exists an uncovered local type at position Pi such that P0..Pi does not contain any uncovered generic parameters

impl<T> Trait<Local> for T {} also results in this error

That's correct of course, I didn't want to increase the verbosity too much.

What do you think of appending "before any uncovered generic type parameters". This again isn't totally bullet proof as P0 is only logically before the other Pn but is not before them in the source.

maybe something like:

"note: impl has uncovered type parameters before any local types"

"note: for more information see "

I think it's not so clear that "no local types" is also problematic when inverted like this. I prefer the original negated version. I do like the shortened "local type" instead of "types from inside the current crate", when we link to the reference anyways I think we can get away with it as it expands on what a "local type" is:

"note: impl doesn't have any local type before any uncovered type parameters"

"note: for more information see https://doc.rust-lang.org/reference/items/implementations.html#orphan-rules"

I'm guessing that's the link you meant to add here? Is it ok to link to a fragment of the reference?

I'll see if I can figure out how to add multi line notes (multiple notes?).

mutliple notes, yeah

your suggestion looks good to me

spastorino · 2024-08-06T15:34:10Z

r? @lcnr (as you're already reviewing it), but this looks good to me with the last suggestion

lcnr · 2024-08-12T08:36:45Z

tests/ui/coherence/coherence-cow.re_b.stderr

@@ -5,7 +5,8 @@ LL | impl<T> Remote for Pair<Cover<T>,T> { }
   | ^^^^^^^^^^^^^^^^^^^----------------
   | |                  |
   | |                  `Pair` is not defined in the current crate
-   | impl doesn't use any uncovered types from inside the current crate
+   | impl doesn't have any local type before any uncovered type parameters
+   | for more information see https://doc.rust-lang.org/reference/items/implementations.html#orphan-rules


vibe: I feel like these two lines should be notes, not labels

lcnr · 2024-08-12T08:37:12Z

one nit, apart from that r=me

lcnr · 2024-08-14T06:48:25Z

going through my list of active reviews today @rustbot author

Dylan-DPC · 2024-09-22T14:32:55Z

@cafce25 any updates on this? thanks

cafce25 · 2024-09-26T17:25:10Z

@Dylan-DPC Thanks for checking in, dropped the ball a bit here. I've tried to just convert the labels to notes, but that leads to the notes being mixed with repeats of the span which seems suboptimal so I've also moved them to the note field which seems a lot cleaner. @rustbot review

lcnr · 2024-09-27T07:41:50Z

@bors r+ rollup

thanks

bors · 2024-09-27T07:41:53Z

📌 Commit b89c620 has been approved by lcnr

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#128391 (Change orphan hint from "only" to "any uncovered type inside...") - rust-lang#131583 (Setting up indirect access to external data for loongarch64-linux-{musl,ohos}) - rust-lang#131595 (rustdoc-JSON: Rename "object safe" to "dyn compatible") - rust-lang#131748 (cleanup canonical queries) - rust-lang#131798 (llvm: Tolerate propagated range metadata) - rust-lang#131815 (compiler: use `is_none_or` where it is clearly better) - rust-lang#131822 (extract `expr_assign_expected_bool_error`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#128391 - cafce25:issue-128390, r=lcnr Change orphan hint from "only" to "any uncovered type inside..." Fix rust-lang#128390

Change orphan hint from "only" to "any uncovered type inside..."

9ce811c

rustbot assigned spastorino Jul 30, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 30, 2024

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2024

Adjust orphan note in tests

86a9959

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 30, 2024

lcnr reviewed Jul 31, 2024

View reviewed changes

rustbot assigned lcnr and unassigned spastorino Aug 6, 2024

Add more information link to orphan impls

ca94dd5

lcnr reviewed Aug 12, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2024

alex-semenyuk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 19, 2024

Make new information notes instead of labels

b89c620

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 26, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2024

matthiaskrgr mentioned this pull request Oct 17, 2024

Rollup of 7 pull requests #131827

Merged

bors merged commit 21c57f5 into rust-lang:master Oct 17, 2024
6 checks passed

rustbot added this to the 1.84.0 milestone Oct 17, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 17, 2024

Unrolled build for rust-lang#128391

6741b73

Rollup merge of rust-lang#128391 - cafce25:issue-128390, r=lcnr Change orphan hint from "only" to "any uncovered type inside..." Fix rust-lang#128390

cafce25 deleted the issue-128390 branch October 21, 2024 12:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change orphan hint from "only" to "any uncovered type inside..." #128391

Change orphan hint from "only" to "any uncovered type inside..." #128391

cafce25 commented Jul 30, 2024

rustbot commented Jul 30, 2024

This comment has been minimized.

cafce25 commented Jul 30, 2024

cafce25 commented Jul 30, 2024

lcnr Jul 31, 2024 •

edited

Loading

cafce25 Jul 31, 2024 •

edited

Loading

lcnr Aug 1, 2024 •

edited

Loading

cafce25 Aug 4, 2024 •

edited

Loading

lcnr Aug 5, 2024

spastorino commented Aug 6, 2024

lcnr Aug 12, 2024

lcnr commented Aug 12, 2024

lcnr commented Aug 14, 2024

Dylan-DPC commented Sep 22, 2024

cafce25 commented Sep 26, 2024

lcnr commented Sep 27, 2024

bors commented Sep 27, 2024

Change orphan hint from "only" to "any uncovered type inside..." #128391

Change orphan hint from "only" to "any uncovered type inside..." #128391

Conversation

cafce25 commented Jul 30, 2024

rustbot commented Jul 30, 2024

This comment has been minimized.

cafce25 commented Jul 30, 2024

cafce25 commented Jul 30, 2024

lcnr Jul 31, 2024 • edited Loading

Choose a reason for hiding this comment

cafce25 Jul 31, 2024 • edited Loading

Choose a reason for hiding this comment

lcnr Aug 1, 2024 • edited Loading

Choose a reason for hiding this comment

cafce25 Aug 4, 2024 • edited Loading

Choose a reason for hiding this comment

lcnr Aug 5, 2024

Choose a reason for hiding this comment

spastorino commented Aug 6, 2024

lcnr Aug 12, 2024

Choose a reason for hiding this comment

lcnr commented Aug 12, 2024

lcnr commented Aug 14, 2024

Dylan-DPC commented Sep 22, 2024

cafce25 commented Sep 26, 2024

lcnr commented Sep 27, 2024

bors commented Sep 27, 2024

lcnr Jul 31, 2024 •

edited

Loading

cafce25 Jul 31, 2024 •

edited

Loading

lcnr Aug 1, 2024 •

edited

Loading

cafce25 Aug 4, 2024 •

edited

Loading